Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated ContainerRegistry/Registries to new dependency approach #1823

Merged
merged 19 commits into from
Oct 4, 2022
Merged

[Modules] Updated ContainerRegistry/Registries to new dependency approach #1823

merged 19 commits into from
Oct 4, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Updated ContainerRegistry/Registries to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
ContainerRegistry: Registries

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Aug 30, 2022
@AlexanderSehr AlexanderSehr self-assigned this Aug 30, 2022
@AlexanderSehr AlexanderSehr mentioned this pull request Aug 30, 2022
Closed
@github-actions
Copy link

github-actions bot commented Aug 30, 2022 •
edited

Unit Test Results

    1 files  ±    0      1 suites  ±0   1m 9s ⏱️ - 2m 40s
129 tests  - 318  126 ✔️  - 316  3 💤  - 2  0 ❌ ±0 
156 runs   - 295  150 ✔️  - 296  6 💤 +1  0 ❌ ±0 

Results for commit 3a06e9b. ± Comparison against base commit 9089af9.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
Update ContainerRegistry/registries to new dependencies approach #1929
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 19:13
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 19:13
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 19:13
@eriqua eriqua added the [prio] high importance of the issue: high priority label Sep 27, 2022
eriqua
eriqua requested changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pe.parameters.json module test is missing conversion and causing the pipeline to fail. It was probably added after the initial conversion was done

AlexanderSehr and others added 3 commits October 3, 2022 11:40
@AlexanderSehr @eriqua
Update modules/Microsoft.ContainerRegistry/registries/.test/common/de…
4263630 
…ploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.ContainerRegistry/registries/.test/min/deplo…
b20c55f 
…y.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.ContainerRegistry/registries/.test/encr/depl…
9e9856a 
…oy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
eriqua
eriqua approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 9eb0bdd into main Oct 4, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_ContainerRegistry_Registries branch October 4, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing [prio] high importance of the issue: high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ContainerRegistry/registries to new dependencies approach
2 participants
@AlexanderSehr @eriqua