Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated Network/NetworkInterfaces to new dependency approach #1830

Merged
merged 17 commits into from
Oct 24, 2022
Merged

[Modules] Updated Network/NetworkInterfaces to new dependency approach #1830

merged 17 commits into from
Oct 24, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Aug 30, 2022 •
edited

Description

  • Updated Network/NetworkInterfaces to new dependency approach

Note: Contains a fix from #2246 for the load balancer module. Will disappear once that PR is merged and this here updated

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: NetworkInterfaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Aug 30, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Aug 30, 2022
@AlexanderSehr AlexanderSehr mentioned this pull request Aug 30, 2022
Closed
@github-actions
Copy link

github-actions bot commented Aug 30, 2022 •
edited

Unit Test Results

  1 files    1 suites   1m 2s ⏱️
53 tests 52 ✔️ 1 💤 0 ❌
63 runs  61 ✔️ 2 💤 0 ❌

Results for commit 5900552.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
Update Network/networkInterfaces to new dependencies approach #1950
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 21, 2022 11:40
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner October 21, 2022 11:40
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 21, 2022 12:29
AlexanderSehr and others added 2 commits October 21, 2022 22:29
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/networkInterfaces/.test/min/deploy.t…
9b0f594 
…est.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr
Updated readme
b8814de
eriqua
eriqua approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 3bb007c into main Oct 24, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Network_NetworkInterfaces branch October 24, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Network/networkInterfaces to new dependencies approach
2 participants
@AlexanderSehr @eriqua