Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated Sql/Servers to new dependency approach #1836

Merged
merged 20 commits into from
Oct 13, 2022
Merged

[Modules] Updated Sql/Servers to new dependency approach #1836

merged 20 commits into from
Oct 13, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Updated Sql/Servers to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Sql: Servers

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Aug 30, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Aug 30, 2022
@AlexanderSehr AlexanderSehr mentioned this pull request Aug 30, 2022
Closed
@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
Update Sql/servers to new dependencies approach #1960
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 06:39
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 06:39
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 06:40
AlexanderSehr and others added 5 commits October 13, 2022 17:21
@AlexanderSehr @eriqua
Update modules/Microsoft.Sql/servers/.test/common/dependencies.bicep
9118af7 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Sql/servers/.test/common/deploy.test.bicep
a6ea1d6 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Sql/servers/.test/pe/dependencies.bicep
dcac0f5 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr
Removed default param
a22de0d
@AlexanderSehr
Addressed comments
9cb7276
eriqua
eriqua approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit b3fc58a into main Oct 13, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Sql_Servers branch October 13, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Sql/servers to new dependencies approach
2 participants
@AlexanderSehr @eriqua