-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] Updated virtualNetworkGateways to support AAD VPN #1844
Merged
ChrisSidebotham
merged 10 commits into
main
from
users/csidebotham/1842-feature-request-add-aad-enabled-vpn-config-to-virtual-network-gateway-module
Nov 4, 2022
Merged
[Modules] Updated virtualNetworkGateways to support AAD VPN #1844
ChrisSidebotham
merged 10 commits into
main
from
users/csidebotham/1842-feature-request-add-aad-enabled-vpn-config-to-virtual-network-gateway-module
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…users/csidebotham/1842-feature-request-add-aad-enabled-vpn-config-to-virtual-network-gateway-module
4 tasks
Unit Test Results 1 files ±0 1 suites ±0 29s ⏱️ -36s Results for commit 1e19626. ± Comparison against base commit 3bb007c. This pull request removes 53 and adds 54 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
…ad-enabled-vpn-config-to-virtual-network-gateway-module
AlexanderSehr
added
enhancement
New feature or request
[cat] modules
category: modules
labels
Oct 25, 2022
eriqua
reviewed
Oct 25, 2022
eriqua
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
ChrisSidebotham
deleted the
users/csidebotham/1842-feature-request-add-aad-enabled-vpn-config-to-virtual-network-gateway-module
branch
November 4, 2022 08:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated module to support AAD Configuration for P2S VPN. Pipeline currently failing on resource removal of teh original vpn.parameters.json test file. New test file added
aadvpn.parameters.json
for AAD Configuration VPN and running successfully.Pipeline references
Type of Change
Please delete options that are not relevant.
Checklist