Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated DataProtection Backup Vaults to new dependency approach #1876

Merged
merged 10 commits into from
Oct 1, 2022
Merged

[Modules] Updated DataProtection Backup Vaults to new dependency approach #1876

merged 10 commits into from
Oct 1, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Sep 3, 2022 •
edited

Description

  • Updated DataProtection Backup Vaults to new dependency approach
  • Removed UserAssigned Identity logic as its not supported by the service. If attempted you receive the error message:

    Status Message: Resource type 'Microsoft.DataProtection/BackupVaults' does not support creation of 'SystemAssigned, UserAssigned' resource identity. The supported types are 'SystemAssigned'. (Code:CannotSetResourceIdentity)

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
DataProtection: BackupVaults

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 3, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 3, 2022
@AlexanderSehr AlexanderSehr mentioned this pull request Sep 3, 2022
Closed
@github-actions
Copy link

github-actions bot commented Sep 3, 2022 •
edited

Unit Test Results

  1 files    1 suites   55s ⏱️
89 tests 87 ✔️ 2 💤 0 ❌
96 runs  93 ✔️ 3 💤 0 ❌

Results for commit ba9dc74.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
Update DataProtection/backupVaults to new dependencies approach #1933
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 06:19
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 06:19
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 06:19
@eriqua eriqua added the [prio] high importance of the issue: high priority label Oct 1, 2022
eriqua
eriqua approved these changes Oct 1, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 2ab89f5 into main Oct 1, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_dataProtection_backupVaults branch October 1, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing [prio] high importance of the issue: high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update DataProtection/backupVaults to new dependencies approach
2 participants
@AlexanderSehr @eriqua