Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated Logic Workflows to new dependency approach #1880

Merged
merged 11 commits into from
Oct 11, 2022
Merged

[Modules] Updated Logic Workflows to new dependency approach #1880

merged 11 commits into from
Oct 11, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Refactored Logic Workflows to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Logic: Workflows

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 3, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 3, 2022
@github-actions
Copy link

github-actions bot commented Sep 3, 2022 •
edited

Unit Test Results

53 tests   52 ✔️  27s ⏱️
  1 suites    1 💤
  1 files      0 ❌

Results for commit cc02fd2.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr mentioned this pull request Sep 3, 2022
Closed
@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
Update Logic/workflows to new dependencies approach #1941
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 06:14
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 06:14
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 06:14
@eriqua eriqua changed the title [Modules] Refactored Logic Workflows to new dependency approach [Modules] Updated Logic Workflows to new dependency approach Oct 10, 2022
AlexanderSehr and others added 2 commits October 11, 2022 12:56
@AlexanderSehr @eriqua
Update modules/Microsoft.Logic/workflows/.test/common/deploy.test.bicep
490846a 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr
Update to latest
a2c27a9
eriqua
eriqua approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 26d3f62 into main Oct 11, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_LogicWorkflows branch October 11, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Logic/workflows to new dependencies approach
2 participants
@AlexanderSehr @eriqua