Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated NSG to new dependency approach #1886

Merged
merged 8 commits into from
Oct 13, 2022
Merged

[Modules] Updated NSG to new dependency approach #1886

merged 8 commits into from
Oct 13, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Updated NSG to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: NetworkSecurityGroups

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 4, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 4, 2022
@AlexanderSehr AlexanderSehr mentioned this pull request Sep 4, 2022
Closed
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

Unit Test Results

  1 files    1 suites   43s ⏱️
90 tests 88 ✔️ 2 💤 0 ❌
97 runs  94 ✔️ 3 💤 0 ❌

Results for commit beecd13.

@AlexanderSehr AlexanderSehr linked an issue Sep 5, 2022 that may be closed by this pull request
Update Network/networkSecurityGroups to new dependencies approach #1951
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 19, 2022 06:08
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 19, 2022 06:08
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 19, 2022 06:15
@AlexanderSehr AlexanderSehr merged commit 7a98cf3 into main Oct 13, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Network_networkSecurityGroups branch October 13, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla approved these changes

@MariusStorhaug MariusStorhaug Awaiting requested review from MariusStorhaug

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Network/networkSecurityGroups to new dependencies approach
2 participants
@AlexanderSehr @ahmadabdalla