Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Configure privateDnsZoneGroups on redisCache #1927

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Sep 5, 2022

Description

Adding privateDNSResourceIds to main test file

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Cache: Redis

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added [cat] modules category: modules [cat] testing category: testing labels Sep 5, 2022
@eriqua eriqua requested a review from a team as a code owner September 5, 2022 17:44
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Unit Test Results

  1 files    1 suites   29s ⏱️
52 tests 52 ✔️ 0 💤 0
53 runs  53 ✔️ 0 💤 0

Results for commit 29f3849.

♻️ This comment has been updated with latest results.

@eriqua eriqua marked this pull request as draft September 5, 2022 22:23
@eriqua eriqua marked this pull request as ready for review September 6, 2022 08:55
@eriqua eriqua enabled auto-merge (squash) September 6, 2022 08:55
@eriqua eriqua merged commit a203401 into main Sep 6, 2022
@eriqua eriqua deleted the users/erikag/1901-redis-dns branch September 6, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure privateDnsZoneGroups on redisCache (redisCache - privatelink.redis.cache.windows.net)
2 participants