Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Configure privateDnsZoneGroups on ACR #1999

Merged
merged 5 commits into from
Sep 9, 2022

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Sep 9, 2022

Description

Updating networking. In particular

  • public network access is set to disabled if private endpoints are set and if networkRuleSetIpRules are not set
  • add privateDnsZoneGroups on tests using private endpoints
  • update common test to use both private endpoints and networkRuleSetIpRules (public network access is not disabled but set to selected networks)
  • add test using private endpoints only (public network access gets automatically disabled)
  • add note in networking parameter descriptions that the Premium sku is required

Version update

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
ContainerRegistry: Registries

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Sep 9, 2022
@eriqua eriqua requested a review from a team as a code owner September 9, 2022 15:38
@eriqua eriqua enabled auto-merge (squash) September 9, 2022 15:42
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Unit Test Results

49 tests   49 ✔️  23s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 6241bb8.

@eriqua eriqua merged commit b416e4b into main Sep 9, 2022
@eriqua eriqua deleted the users/erikag/1991-acr-dns branch September 9, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules [cat] testing category: testing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure privateDnsZoneGroups on ACR (registry - privatelink.azurecr.io)
2 participants