Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated KeyVault vaults to new dependencies approach #2002

Merged
merged 4 commits into from
Sep 18, 2022
Merged

[Modules] Updated KeyVault vaults to new dependencies approach #2002

merged 4 commits into from
Sep 18, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Updated KeyVault vaults to new dependencies approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
KeyVault: Vaults

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 9, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022 •
edited

Unit Test Results

    1 files      1 suites   1m 38s ⏱️
168 tests 165 ✔️ 3 💤 0 ❌
175 runs  171 ✔️ 4 💤 0 ❌

Results for commit 3061cc5.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr linked an issue Sep 10, 2022 that may be closed by this pull request
Update KeyVault/vaults to new dependencies approach #2001
Closed
@AlexanderSehr @eriqua
Update modules/Microsoft.KeyVault/vaults/.test/common/dependencies.bicep
3061cc5 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@eriqua eriqua marked this pull request as ready for review September 18, 2022 16:06
@eriqua eriqua requested a review from a team as a code owner September 18, 2022 16:06
eriqua
eriqua approved these changes Sep 18, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit b545d93 into main Sep 18, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_KeyVault_vaults branch September 18, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update KeyVault/vaults to new dependencies approach
2 participants
@AlexanderSehr @eriqua