Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Update Network FrontDoors to new dependency approach #2050

Merged
merged 9 commits into from
Oct 6, 2022
Merged

[Modules] Update Network FrontDoors to new dependency approach #2050

merged 9 commits into from
Oct 6, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Update Network FrontDoors to new dependency approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: Frontdoors

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 16, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 16, 2022
@AlexanderSehr AlexanderSehr linked an issue Sep 16, 2022 that may be closed by this pull request
Update Network/frontDoors to new dependencies approach #2049
Closed
@github-actions
Copy link

github-actions bot commented Sep 16, 2022 •
edited

Unit Test Results

  1 files    1 suites   38s ⏱️
53 tests 52 ✔️ 1 💤 0 ❌
60 runs  58 ✔️ 2 💤 0 ❌

Results for commit 8f12344.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 18, 2022 21:43
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 18, 2022 21:43
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 18, 2022 21:43
eriqua
eriqua approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit c207b83 into main Oct 6, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Network_frontDoors branch October 6, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Network/frontDoors to new dependencies approach
2 participants
@AlexanderSehr @eriqua