Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Update Network Route Tables to new dependencies approach #2076

Merged
merged 9 commits into from
Oct 5, 2022
Merged

[Modules] Update Network Route Tables to new dependencies approach #2076

merged 9 commits into from
Oct 5, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Update Network Route Tables to new dependencies approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: RouteTables

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 20, 2022 17:28
@AlexanderSehr AlexanderSehr self-assigned this Sep 20, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 20, 2022
@AlexanderSehr AlexanderSehr linked an issue Sep 20, 2022 that may be closed by this pull request
Update Network/routeTables to new dependencies approach #2075
Closed
@github-actions
Copy link

Unit Test Results

  1 files  ±  0    1 suites  ±0   30s ⏱️ -38s
52 tests  - 76  50 ✔️  - 75  2 💤  - 1  0 ❌ ±0 
59 runs   - 86  56 ✔️  - 84  3 💤  - 2  0 ❌ ±0 

Results for commit 6d424e6. ± Comparison against base commit e4f0b02.

AlexanderSehr and others added 6 commits October 5, 2022 14:37
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/routeTables/.test/common/deploy.test…
d78307f 
….bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/routeTables/.test/common/deploy.test…
91491b6 
….bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/routeTables/.test/common/deploy.test…
1ea80b3 
….bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/routeTables/.test/min/deploy.test.bicep
1794cb7 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/routeTables/.test/min/deploy.test.bicep
9636bbe 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/routeTables/.test/min/deploy.test.bicep
ed0bef8 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 5, 2022 12:38
eriqua
eriqua approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 34f5d57 into main Oct 5, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Network_routeTables branch October 5, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Network/routeTables to new dependencies approach
2 participants
@AlexanderSehr @eriqua