Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Update Network Public IP Addresses to new dependencies approach #2080

Merged
merged 10 commits into from
Sep 28, 2022
Merged

[Modules] Update Network Public IP Addresses to new dependencies approach #2080

merged 10 commits into from
Sep 28, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Update Network Public IP Addresses to new dependencies approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: PublicIpAddresses

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 20, 2022 18:56
@AlexanderSehr AlexanderSehr self-assigned this Sep 20, 2022
@github-actions
Copy link

github-actions bot commented Sep 20, 2022 •
edited

Unit Test Results

  1 files  ±  0    1 suites  ±0   32s ⏱️ -36s
53 tests  - 75  52 ✔️  - 73  1 💤  - 2  0 ❌ ±0 
60 runs   - 85  58 ✔️  - 82  2 💤  - 3  0 ❌ ±0 

Results for commit 47e7464. ± Comparison against base commit e4f0b02.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 20, 2022
@eriqua eriqua added the [prio] high importance of the issue: high priority label Sep 27, 2022
AlexanderSehr and others added 6 commits September 28, 2022 16:50
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/publicIPAddresses/.test/common/deplo…
b0caf17 
…y.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/publicIPAddresses/.test/common/deplo…
94aa9b7 
…y.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/publicIPAddresses/.test/common/deplo…
f6c157f 
…y.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/publicIPAddresses/.test/min/deploy.t…
f2b508a 
…est.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/publicIPAddresses/.test/min/deploy.t…
0053b5f 
…est.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/publicIPAddresses/.test/min/deploy.t…
6ffc062 
…est.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 28, 2022 14:51
eriqua
eriqua approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 491746a into main Sep 28, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Network_publicIPAddresses branch September 28, 2022 14:59
@AlexanderSehr AlexanderSehr linked an issue Sep 30, 2022 that may be closed by this pull request
Update Network/publicIPAddresses to new dependencies approach #2079
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing [prio] high importance of the issue: high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Network/publicIPAddresses to new dependencies approach
2 participants
@AlexanderSehr @eriqua