Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Update Network PrivateDNSZones to new dependencies approach #2084

Merged
merged 12 commits into from
Oct 4, 2022
Merged

[Modules] Update Network PrivateDNSZones to new dependencies approach #2084

merged 12 commits into from
Oct 4, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Update Network PrivateDNSZones to new dependencies approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: PrivateDnsZones

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 20, 2022 19:30
@AlexanderSehr AlexanderSehr self-assigned this Sep 20, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 20, 2022
@AlexanderSehr AlexanderSehr linked an issue Sep 20, 2022 that may be closed by this pull request
Update Network/privateDnsZones to new dependencies approach #2083
Closed
@github-actions
Copy link

github-actions bot commented Sep 20, 2022 •
edited

Unit Test Results

    1 files  ±    0      1 suites  ±0   2m 56s ⏱️ + 1m 48s
393 tests +265  383 ✔️ +258  10 💤 +7  0 ❌ ±0 
400 runs  +255  389 ✔️ +249  11 💤 +6  0 ❌ ±0 

Results for commit f76411e. ± Comparison against base commit e4f0b02.

♻️ This comment has been updated with latest results.

AlexanderSehr and others added 8 commits October 3, 2022 22:23
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/privateDnsZones/.test/common/deploy.…
3b5c315 
…test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/privateDnsZones/.test/common/deploy.…
71dea3c 
…test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/privateDnsZones/.test/common/deploy.…
cbe7e2d 
…test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/privateDnsZones/.test/min/deploy.tes…
63dd9cb 
…t.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/privateDnsZones/.test/min/deploy.tes…
90c23cb 
…t.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/privateDnsZones/.test/min/deploy.tes…
a226f0a 
…t.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Network/privateDnsZones/.test/min/deploy.tes…
9023613 
…t.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr
Updated readme
140b8b6
eriqua
eriqua approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua added the [prio] high importance of the issue: high priority label Oct 4, 2022
@AlexanderSehr AlexanderSehr merged commit 4ec0ec5 into main Oct 4, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Network_privateDnsZones branch October 4, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing [prio] high importance of the issue: high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Network/privateDnsZones to new dependencies approach
2 participants
@AlexanderSehr @eriqua