Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated Insights ScheduledQueryRules to new dependencies approach & increased test robustness #2096

Merged
merged 8 commits into from
Oct 6, 2022
Merged

[Modules] Updated Insights ScheduledQueryRules to new dependencies approach & increased test robustness #2096

merged 8 commits into from
Oct 6, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Sep 21, 2022 •
edited

Description

  • Updated Insights ScheduledQueryRules to new dependencies approach
  • Increased test robustness

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Insights: ScheduledQueryRules

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 21, 2022 18:22
@AlexanderSehr AlexanderSehr self-assigned this Sep 21, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 21, 2022
@AlexanderSehr AlexanderSehr linked an issue Sep 21, 2022 that may be closed by this pull request
Update Insights/scheduledQueryRules to new dependencies approach #2095
Closed
@github-actions
Copy link

github-actions bot commented Sep 21, 2022 •
edited

Unit Test Results

51 tests   49 ✔️  32s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 263a78a.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr changed the title [Modules] Updated Insights ScheduledQueryRules to new dependencies approach [Modules] Updated Insights ScheduledQueryRules to new dependencies approach & increased test robustness Sep 21, 2022
rahalan
rahalan previously approved these changes Oct 5, 2022
View reviewed changes
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 5, 2022 12:56
eriqua
eriqua approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 3b1fcaa into main Oct 6, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Insights_scheduledQueryRules branch October 6, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

@rahalan rahalan rahalan left review comments

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Insights/scheduledQueryRules to new dependencies approach
3 participants
@AlexanderSehr @eriqua @rahalan