Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated HealthBots to new dependencies approach #2098

Merged
merged 3 commits into from
Oct 6, 2022
Merged

[Modules] Updated HealthBots to new dependencies approach #2098

merged 3 commits into from
Oct 6, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Sep 21, 2022 •
edited

Description

  • Updated HealthBots to new dependencies approach
  • Updated test script to deal better with empty lines (as readme script introduced new empty lines)

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
HealthBot: HealthBots

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 21, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 21, 2022
@AlexanderSehr AlexanderSehr linked an issue Sep 21, 2022 that may be closed by this pull request
Update HealthBot/healthBots to new dependencies approach #2097
Closed
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 21, 2022 18:57
@github-actions
Copy link

Unit Test Results

  1 files    1 suites   31s ⏱️
52 tests 50 ✔️ 2 💤 0 ❌
59 runs  56 ✔️ 3 💤 0 ❌

Results for commit 3411b81.

@AlexanderSehr AlexanderSehr changed the title [Modules ]Updated HealthBots to new dependencies approach & readme script update [Modules ]Updated HealthBots to new dependencies approach & increased test robustness Sep 21, 2022
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 5, 2022 12:53
@eriqua eriqua changed the title [Modules ]Updated HealthBots to new dependencies approach & increased test robustness [Modules ]Updated HealthBots to new dependencies approach Oct 5, 2022
@eriqua eriqua changed the title [Modules ]Updated HealthBots to new dependencies approach [Modules ] Updated HealthBots to new dependencies approach Oct 5, 2022
eriqua
eriqua approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit d4a0f0e into main Oct 6, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_HealthBot_healthBots branch October 6, 2022 09:03
@eriqua eriqua changed the title [Modules ] Updated HealthBots to new dependencies approach [Modules] Updated HealthBots to new dependencies approach Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update HealthBot/healthBots to new dependencies approach
2 participants
@AlexanderSehr @eriqua