Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated Insight Components to new dependencies approach #2104

Merged
merged 8 commits into from
Oct 3, 2022
Merged

[Modules] Updated Insight Components to new dependencies approach #2104

merged 8 commits into from
Oct 3, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Updated Insight Components to new dependencies approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Insights: Components

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 21, 2022 19:59
@AlexanderSehr AlexanderSehr self-assigned this Sep 21, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 21, 2022
@AlexanderSehr AlexanderSehr linked an issue Sep 21, 2022 that may be closed by this pull request
Update Insights/components to new dependencies approach #2103
Closed
@github-actions
Copy link

Unit Test Results

  1 files    1 suites   37s ⏱️
51 tests 49 ✔️ 2 💤 0 ❌
61 runs  58 ✔️ 3 💤 0 ❌

Results for commit d16a64b.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 1, 2022 06:33
@eriqua eriqua added the [prio] high importance of the issue: high priority label Oct 2, 2022
AlexanderSehr and others added 6 commits October 3, 2022 11:38
@AlexanderSehr @eriqua
Update modules/Microsoft.Insights/components/.test/common/deploy.test…
1533c70 
….bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Insights/components/.test/common/deploy.test…
b7c335a 
….bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Insights/components/.test/common/deploy.test…
be16aad 
….bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Insights/components/.test/min/deploy.test.bicep
21fd711 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Insights/components/.test/min/deploy.test.bicep
5661358 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Insights/components/.test/min/deploy.test.bicep
70d10a3 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
eriqua
eriqua approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 36cf38c into main Oct 3, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Insights_components branch October 3, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing [prio] high importance of the issue: high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Insights/components to new dependencies approach
2 participants
@AlexanderSehr @eriqua