Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Virtual Machine - fixed the subnetId (should be subnetResourceId) old reference for the… #2120

Merged
merged 17 commits into from
Sep 25, 2022

Conversation

oliverlabs
Copy link
Contributor

… nicConfigurations array in the readme.md

Fixes Bug Issue #2114

Resolves #2114

Description

Thank you for your contribution !

Please include a summary of the change and which issue is fixed.
Please also include the context.
List any dependencies that are required for this change.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua changed the title fixed the subnetId (should be subnetResourceId) old reference for the… [Fixes] Virtual Machine - fixed the subnetId (should be subnetResourceId) old reference for the… Sep 24, 2022
@eriqua eriqua added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request [cat] modules category: modules and removed bug Something isn't working labels Sep 24, 2022
@oliverlabs
Copy link
Contributor Author

Thanks, @eriqua

Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes suggested:

  • Clean up the settings in .vscode/settings.json, unless there is a valid justification to keep the setting.
  • Regenerate the readme using the provided tool.

.vscode/settings.json Outdated Show resolved Hide resolved
modules/Microsoft.Compute/virtualMachines/readme.md Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
@MariusStorhaug MariusStorhaug merged commit a2ed91a into Azure:main Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: wrong parameter name in the readme.md of the Microsoft.Compute/virtualMachines
3 participants