Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Key Vault - Fix parameter usage section #2171

Merged
merged 7 commits into from
Oct 5, 2022

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Oct 4, 2022

Description

  • Remove outdated vNetId parameter usage
  • Update networkAcls parameter usage
  • Removed parameter value from common test. action: 'Allow' is added by default.
  • Cleaned up variable networkAcls_var from the module

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added bug Something isn't working documentation Improvements or additions to documentation [cat] modules category: modules labels Oct 4, 2022
@eriqua eriqua linked an issue Oct 4, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Unit Test Results

    1 files  ±    0      1 suites  ±0   1m 30s ⏱️ - 1m 50s
168 tests  - 224  165 ✔️  - 216  3 💤  - 8  0 ±0 
175 runs   - 231  171 ✔️  - 222  4 💤  - 9  0 ±0 

Results for commit 57b0b12. ± Comparison against base commit 14c6692.

♻️ This comment has been updated with latest results.

@eriqua eriqua marked this pull request as ready for review October 5, 2022 08:40
@eriqua eriqua requested a review from a team as a code owner October 5, 2022 08:40
@eriqua eriqua merged commit 222e587 into main Oct 5, 2022
@eriqua eriqua deleted the users/erikag/2159-kv-nacls branch October 5, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules documentation Improvements or additions to documentation hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants