Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Removed generated name feature from EventHub #2174

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Oct 6, 2022

Description

Removed generated name feature from EventHub

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
EventHub: Namespaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Unit Test Results

    1 files  ±    0      1 suites  ±0   2m 49s ⏱️ + 2m 3s
281 tests +226  276 ✔️ +222  5 💤 +4  0 ±0 
298 runs  +216  291 ✔️ +213  7 💤 +3  0 ±0 

Results for commit 8f672c8. ± Comparison against base commit f1f0552.

This pull request removes 55 and adds 281 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [accounts] should use one of the recent API version(s). Currently using [2021-10-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.CognitiveServices/accounts] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All required parameters in template file (deploy.json) should exist in parameters files
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/authorizationRules] used resource type [namespaces/authorizationRules] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/disasterRecoveryConfigs] used resource type [namespaces/disasterRecoveryConfigs] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventhubs/authorizationRules] used resource type [namespaces/eventhubs/authorizationRules] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventhubs/consumergroups] used resource type [namespaces/eventhubs/consumergroups] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventhubs] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventhubs] used resource type [namespaces/eventhubs/authorizationRules] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventhubs] used resource type [namespaces/eventhubs/consumergroups] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventhubs] used resource type [namespaces/eventhubs] should use one of the recent API version(s). Currently using [2021-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/eventhubs] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventHub/namespaces/networkRuleSets] used resource type [namespaces/networkRuleSets] should use one of the recent API version(s). Currently using [2021-11-01]
…
This pull request removes 1 skipped test and adds 5 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.CognitiveServices/accounts] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.EventHub/namespaces/authorizationRules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.EventHub/namespaces/disasterRecoveryConfigs] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.EventHub/namespaces/eventhubs/authorizationRules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.EventHub/namespaces/eventhubs/consumergroups] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.EventHub/namespaces] *parameters.json files in the .test folder should be valid json

@eriqua eriqua changed the title [Modules] Removed generated name feature from [Modules] Removed generated name feature from EventHub Oct 6, 2022
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules labels Oct 6, 2022
@eriqua eriqua marked this pull request as ready for review October 6, 2022 08:42
@eriqua eriqua requested a review from a team as a code owner October 6, 2022 08:42
@AlexanderSehr
Copy link
Contributor

Where the hell is this coming from 😄

@eriqua
Copy link
Contributor Author

eriqua commented Oct 6, 2022

Where the hell is this coming from 😄

Apparently we missed it. If it wasn't for PSRule I wouldn't have found it 👀

@eriqua eriqua merged commit 8cf7285 into main Oct 6, 2022
@eriqua eriqua deleted the users/erikag/evh-unique branch October 6, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants