Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] New module DNS Private Resolvers with new dependency approach #2202

Merged
merged 8 commits into from
Oct 13, 2022
Merged

[Modules] New module DNS Private Resolvers with new dependency approach #2202

merged 8 commits into from
Oct 13, 2022

Conversation

ChrisSidebotham
Copy link
Contributor

Description

Added new modules for Microsoft.Network/DNSResolvers, added with new dependency approach for Virtual Network/Subnet Requirements.

Pipeline references

Pipeline
Build Status

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ChrisSidebotham ChrisSidebotham requested a review from a team as a code owner October 11, 2022 11:27
@ChrisSidebotham ChrisSidebotham linked an issue Oct 11, 2022 that may be closed by this pull request
[Feature Request]: Create new module for Private DNS Resolver Service #2199
Closed
@ChrisSidebotham ChrisSidebotham added the [cat] modules category: modules label Oct 11, 2022
@eriqua eriqua changed the title [Modules] DNS Private Resolvers with new dependency approach [Modules] New module DNS Private Resolvers with new dependency approach Oct 12, 2022
@ahmadabdalla ahmadabdalla merged commit 204bdf2 into main Oct 13, 2022
@ahmadabdalla ahmadabdalla deleted the users/csidebotham/2199-feature-request-create-new-module-for-private-dns-resolver-service branch October 13, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@ChrisSidebotham ChrisSidebotham

Labels
[cat] modules category: modules hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Create new module for Private DNS Resolver Service
4 participants
@ChrisSidebotham @AlexanderSehr @ahmadabdalla @eriqua