Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated Synapse Privatelink Hubs (Azure Synapse Analytics) to new dependencies approach #2228

Merged
merged 24 commits into from
Oct 18, 2022
Merged

[Modules] Updated Synapse Privatelink Hubs (Azure Synapse Analytics) to new dependencies approach #2228

merged 24 commits into from
Oct 18, 2022

Conversation

elanzel
Copy link
Contributor

@elanzel elanzel commented Oct 14, 2022

Description

Updated Azure Synapse Analytics to new dependencies approach.

closes #2227

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Synapse: PrivateLinkHubs

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

elanzel and others added 15 commits October 7, 2022 13:15
@elanzel
log analytics workspace new dependencies
284e3c4
@elanzel
removed parameters.json
e3e5bbb
@elanzel
readme update
ffcef47
@elanzel
description param update
9140ae8
@elanzel @eriqua
Update modules/Microsoft.OperationalInsights/workspaces/.test/common/…
70f25fb 
…dependencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@elanzel @eriqua
Update modules/Microsoft.OperationalInsights/workspaces/.test/common/…
af0f8fe 
…dependencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@elanzel @eriqua
Update modules/Microsoft.OperationalInsights/workspaces/.test/common/…
0251f35 
…deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@elanzel @eriqua
Update modules/Microsoft.OperationalInsights/workspaces/.test/common/…
253af39 
…deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@elanzel @eriqua
Update modules/Microsoft.OperationalInsights/workspaces/.test/common/…
5373595 
…deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@elanzel @eriqua
Update modules/Microsoft.OperationalInsights/workspaces/.test/min/dep…
35df7da 
…loy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@elanzel @eriqua
Update modules/Microsoft.OperationalInsights/workspaces/.test/min/dep…
436fe3c 
…loy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@elanzel @eriqua
Update modules/Microsoft.OperationalInsights/workspaces/.test/min/dep…
c571cde 
…loy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@elanzel @AlexanderSehr
Update modules/Microsoft.OperationalInsights/workspaces/.test/common/…
1ebf1b2 
…deploy.test.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@elanzel
synapse analytics draft
7748600
@elanzel
shortname update for common test module
cc26057
@elanzel elanzel added [cat] modules category: modules [cat] testing category: testing labels Oct 14, 2022
@elanzel elanzel requested a review from a team as a code owner October 14, 2022 17:25
@elanzel elanzel self-assigned this Oct 14, 2022
@github-actions
Copy link

Unit Test Results

  1 files  ±    0    1 suites  ±0   33s ⏱️ - 2m 4s
54 tests  - 303  53 ✔️  - 298  1 💤  - 5  0 ❌ ±0 
61 runs   - 323  59 ✔️  - 316  2 💤  - 7  0 ❌ ±0 

Results for commit 1646221. ± Comparison against base commit 0bbed35.

elanzel and others added 5 commits October 18, 2022 17:04
@elanzel @eriqua
Update modules/Microsoft.Synapse/privateLinkHubs/.test/common/depende…
a877703 
…ncies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@elanzel @eriqua
Update modules/Microsoft.Synapse/privateLinkHubs/.test/common/depende…
8a2c752 
…ncies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@elanzel @eriqua
Update modules/Microsoft.Synapse/privateLinkHubs/.test/common/depende…
abc0259 
…ncies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@elanzel
removed workspace change
cb16d3d
@elanzel
Merge branch 'users/eanzel/2227_synapseprivlink' of https://github.co…
56039b5 
…m/Azure/ResourceModules into users/eanzel/2227_synapseprivlink
eriqua
eriqua approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua merged commit f06faee into main Oct 18, 2022
@eriqua eriqua deleted the users/eanzel/2227_synapseprivlink branch October 18, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

@AlexanderSehr AlexanderSehr Awaiting requested review from AlexanderSehr

Assignees

@elanzel elanzel

Labels
[cat] modules category: modules [cat] testing category: testing hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Synapse/privateLinkHubs to new dependencies approach
3 participants
@elanzel @AlexanderSehr @eriqua