Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Extend Web Sites with kvrefidentity #2236

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

fblix
Copy link
Contributor

@fblix fblix commented Oct 19, 2022

Description

This PR will introduce the ability to define a specific identity to be used by the app service when authenticating to a keyvault.
Previously this missing property could lead to issues when using a system- and a user-assigned identity at the same time.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

| Pipeline |
| Web: Sites |
| |

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Felix Borst added 3 commits October 19, 2022 11:25
@fblix fblix marked this pull request as ready for review October 19, 2022 10:06
@fblix fblix requested a review from a team as a code owner October 19, 2022 10:06
@eriqua eriqua changed the title Users/f blix/sites kvrefidentity [Modules] Extend Web Sites with kvrefidentity Oct 19, 2022
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua merged commit df21b01 into main Oct 19, 2022
@eriqua eriqua deleted the users/f_blix/sites-kvrefidentity branch October 19, 2022 10:29
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules hacktoberfest-accepted labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants