Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Managed instance support TLS setting #2262

Merged
merged 2 commits into from
Nov 2, 2022
Merged

[Modules] Managed instance support TLS setting #2262

merged 2 commits into from
Nov 2, 2022

Conversation

coolhome
Copy link
Contributor

@coolhome coolhome commented Oct 31, 2022 •
edited

Description

Implements SQL Managed Instances to have Minimum TLS version. This PR fixes #2261.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@coolhome coolhome requested a review from a team as a code owner October 31, 2022 22:14
@coolhome
Copy link
Contributor Author

@microsoft-github-policy-service agree

@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Nov 1, 2022
AlexanderSehr
AlexanderSehr previously approved these changes Nov 1, 2022
View reviewed changes
@AlexanderSehr AlexanderSehr merged commit 1d0b5f1 into Azure:main Nov 2, 2022
@AlexanderSehr
Copy link
Contributor

Approved and merged. Thank you very much for your contribution @coolhome 💪

@eriqua eriqua changed the title Managed instance support TLS setting (Fixes #2261) [Modules] Managed instance support TLS setting Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@coolhome coolhome

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add minimalTlsVersion to SQL Managed Instances
2 participants
@coolhome @AlexanderSehr