Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utilities] Updated compatability of ConvertTo-ARMTemplate utility to new dependencies approach #2375

Merged
merged 19 commits into from
Nov 30, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 27, 2022

Description

  • Updated compatability of ConvertTo-ARMTemplate utility to new dependencies approach
  • Updated test cases
  • Enabled multi-threading & invocation

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
.Platform: Test - ConvertTo-ARMTemplate.ps1

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Nov 27, 2022
@AlexanderSehr AlexanderSehr added [cat] testing category: testing [cat] utilities category: utilities labels Nov 27, 2022
@github-actions
Copy link

Test Results

  1 files  ±    0    1 suites  ±0   0s ⏱️ - 3m 5s
  6 tests  - 351    0 ✔️  - 351  0 💤  - 6  6 +6 
17 runs   - 367  11 ✔️  - 364  0 💤  - 9  6 +6 

For more details on these failures, see this check.

Results for commit d1e9f53. ± Comparison against base commit 3ad0e19.

@github-actions
Copy link

github-actions bot commented Nov 27, 2022

Test Results

  1 files  ±  0    1 suites  ±0   30s ⏱️ - 19m 3s
52 tests +47  50 ✔️ +45  2 💤 +2  0 ±0 
59 runs  +44  56 ✔️ +41  3 💤 +3  0 ±0 

Results for commit a002ed8. ± Comparison against base commit 3ad0e19.

This pull request removes 5 and adds 52 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/tools/tests/ConvertTo-ARMTemplate.Tests.ps1 ‑ Test flag to including children.All Azure DevOps pipeline files are changed
/home/runner/work/ResourceModules/ResourceModules/utilities/tools/tests/ConvertTo-ARMTemplate.Tests.ps1 ‑ Test flag to including children.All GitHub workflow files are updated
/home/runner/work/ResourceModules/ResourceModules/utilities/tools/tests/ConvertTo-ARMTemplate.Tests.ps1 ‑ Test flag to including children.All bicep files are removed
/home/runner/work/ResourceModules/ResourceModules/utilities/tools/tests/ConvertTo-ARMTemplate.Tests.ps1 ‑ Test flag to including children.All deploy.bicep files are converted to deploy.json
/home/runner/work/ResourceModules/ResourceModules/utilities/tools/tests/ConvertTo-ARMTemplate.Tests.ps1 ‑ Test flag to including children.All json files have metadata removed
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Resources/resourceGroups] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Resources/resourceGroups] used resource type [resourceGroups] should use one of the recent API version(s). Currently using [2019-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Resources/resourceGroups] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Resources/resourceGroups] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Resources/resourceGroups] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Resources/resourceGroups] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Resources/resourceGroups] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Resources/resourceGroups] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Resources/resourceGroups] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Resources/resourceGroups] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
…

♻️ This comment has been updated with latest results.

Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 3b5d186 into main Nov 30, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/converttoARMUpdate branch November 30, 2022 09:25
@eriqua eriqua changed the title [Utilties] Updated compatability of ConvertTo-ARMTemplate utility to new dependencies approach [Utilities] Updated compatability of ConvertTo-ARMTemplate utility to new dependencies approach Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] testing category: testing [cat] utilities category: utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants