Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Remove identity from RSV common test #2388

Merged
merged 27 commits into from
Nov 30, 2022
Merged

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Nov 29, 2022

Description

Remove identity from RSV common test
Add note to known issues
Open new bug #2391 to monitor the issue going forward

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
RecoveryServices: Vaults

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link

github-actions bot commented Nov 29, 2022

Test Results

    1 files  ±  0      1 suites  ±0   4m 29s ⏱️ +54s
429 tests +72  417 ✔️ +66  12 💤 +6  0 ±0 
443 runs  +59  429 ✔️ +54  14 💤 +5  0 ±0 

Results for commit 0686faf. ± Comparison against base commit 689478f.

♻️ This comment has been updated with latest results.

@eriqua eriqua changed the title [Modules] Remove user assigned identity from RSV common test [Modules] Remove identity from RSV common test Nov 29, 2022
@eriqua eriqua marked this pull request as ready for review November 30, 2022 09:41
@eriqua eriqua requested a review from a team as a code owner November 30, 2022 09:41
@eriqua eriqua enabled auto-merge (squash) November 30, 2022 09:42
@eriqua eriqua merged commit 982180d into main Nov 30, 2022
@eriqua eriqua deleted the users/erikag/rsvInstance branch November 30, 2022 09:46
@eriqua eriqua linked an issue Nov 30, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Recovery Services Vaults pipeline
2 participants