-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] Connect Azure Firewall to a VirtualHub #2395
Merged
fblix
merged 19 commits into
main
from
users/fblix_jpeasier/1627-azure-firewalls-to-virtual-hubs
Jan 9, 2023
Merged
[Modules] Connect Azure Firewall to a VirtualHub #2395
fblix
merged 19 commits into
main
from
users/fblix_jpeasier/1627-azure-firewalls-to-virtual-hubs
Jan 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs' of https://github.com/Azure/ResourceModules into users/fblix_jpeasier/1627-azure-firewalls-to-virtual-hubs
…bs' of https://github.com/Azure/ResourceModules into users/fblix_jpeasier/1627-azure-firewalls-to-virtual-hubs
…bs' of https://github.com/Azure/ResourceModules into users/fblix_jpeasier/1627-azure-firewalls-to-virtual-hubs
fblix
changed the title
Users/fblix jpeasier/1627 azure firewalls to virtual hubs
[Bugfix] Connect Azure Firewall to a VirtualHub
Dec 1, 2022
fblix
changed the title
[Bugfix] Connect Azure Firewall to a VirtualHub
[Modules] Connect Azure Firewall to a VirtualHub
Dec 1, 2022
…bs' of https://github.com/Azure/ResourceModules into users/fblix_jpeasier/1627-azure-firewalls-to-virtual-hubs
AlexanderSehr
approved these changes
Jan 9, 2023
fblix
deleted the
users/fblix_jpeasier/1627-azure-firewalls-to-virtual-hubs
branch
January 9, 2023 18:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces and fixes the functionality towards Azure Firewalls in combination with Secured Virtual Hubs.
A bit of background:
An Azure Firewall can be configured to either run in an VirtualNetwork setup (Sku: AzFw_Vnet) or in a Secured Virtual Hub context (Sku: AzFw_hub). A firewall can therefore be deployed without a virtual network and instead with a secured virtual hub.
It is also not possible to attach a Azure Firewall to a Virtual Hub but only in reverse order. If you allow the AzureFirewallId property in the virtual hub two things happen:
{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.","details":[{"code":"AzureFirewallSkuCannotBeUpdated","message":"Update on SKU is not supported for Azure Firewall standard."}]}
{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.","details":[{"code":"AzureFirewallSkuCannotBeUpdated","message":"Update on SKU is not supported for Azure Firewall premium (Sku name change is not allowed)."}]}
Following the documentation https://learn.microsoft.com/en-us/azure/firewall-manager/deployment-overview reveals that there is a specific deployment order to be followed. Thus, we only enabled the connection between firewall and vhub to be established from the firewall side and NOT vice-versa to keep control of the deployment order
Pipeline references
Type of Change
Please delete options that are not relevant.
Checklist