Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated variable usage in test cases & added docs recommendation #2400

Merged
merged 10 commits into from
Jan 4, 2023
Merged

[Modules] Updated variable usage in test cases & added docs recommendation #2400

merged 10 commits into from
Jan 4, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Dec 2, 2022 •
edited

Description

  • Updated variable usage in test cases
  • Added docs recommendation

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AppConfiguration: ConfigurationStores

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr added documentation Improvements or additions to documentation [cat] modules category: modules [cat] testing category: testing labels Dec 2, 2022
@AlexanderSehr
Copy link
Contributor Author

Linked to #2038

@AlexanderSehr AlexanderSehr linked an issue Dec 2, 2022 that may be closed by this pull request
Discuss the need of a variables section in test templates #2397
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review December 13, 2022 15:05
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner December 13, 2022 15:05
@AlexanderSehr AlexanderSehr marked this pull request as draft December 13, 2022 15:50
@AlexanderSehr AlexanderSehr marked this pull request as ready for review December 30, 2022 12:38
@github-actions
Copy link

Test Results

    1 files  ±    0      1 suites  ±0   41s ⏱️ - 1m 57s
  92 tests  - 186    90 ✔️  - 184  2 💤  - 2  0 ❌ ±0 
109 runs   - 199  105 ✔️  - 196  4 💤  - 3  0 ❌ ±0 

Results for commit d58a417. ± Comparison against base commit baaeb4a.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 30, 2022 12:44
eriqua
eriqua approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit a79b3d2 into main Jan 4, 2023
@AlexanderSehr AlexanderSehr deleted the users/alsehr/apiDepMinor branch January 4, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla left review comments

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discuss the need of a variables section in test templates
3 participants
@AlexanderSehr @ahmadabdalla @eriqua