Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Add support for Virtual Machine Automatic VM Guest Patching #2429

Merged
merged 14 commits into from
Dec 22, 2022
Merged

[Modules] Add support for Virtual Machine Automatic VM Guest Patching #2429

merged 14 commits into from
Dec 22, 2022

Conversation

tyconsulting
Copy link
Contributor

@tyconsulting tyconsulting commented Dec 11, 2022 •
edited

Description

Add support for Virtual Machine Automatic VM Guest Patching. Addressing issue #2428

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: VirtualMachines

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@tyconsulting tyconsulting requested a review from a team as a code owner December 11, 2022 08:28
@tyconsulting
Copy link
Contributor Author

tyconsulting commented Dec 11, 2022 •
edited

@microsoft-github-policy-service agree
@microsoft-github-policy-service agree company="TY-Consulting"

@tyconsulting
Copy link
Contributor Author

@microsoft-github-policy-service agree company="TY-Consulting"

@tyconsulting
Copy link
Contributor Author

@microsoft-github-policy-service agree

@eriqua eriqua linked an issue Dec 11, 2022 that may be closed by this pull request
[Feature Request]: Add support for Virtual Machine Automatic VM Guest Patching #2428
Closed
@eriqua eriqua changed the title Add support for Virtual Machine Automatic VM Guest Patching [Modules] Add support for Virtual Machine Automatic VM Guest Patching Dec 11, 2022
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules labels Dec 11, 2022
@tyconsulting
Copy link
Contributor Author

@AlexanderSehr is there anything else I need to do or could you please review this again?

@tyconsulting
Copy link
Contributor Author

@eriqua @ahmadabdalla @AlexanderSehr I've also just added another parameter called pathcAssessmentMode, it represents the Periodic assessment setting in Update Management Center on the portal.

@tyconsulting
Copy link
Contributor Author

@AlexanderSehr I have accepted all the changes and resolved the conflict on the readme. please approve. thanks

@tyconsulting @AlexanderSehr
Update modules/Microsoft.Compute/virtualMachines/deploy.bicep
9d26605 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 22, 2022 07:22
@AlexanderSehr AlexanderSehr merged commit 723a7f4 into Azure:main Dec 22, 2022
@tyconsulting tyconsulting deleted the feature/vm-patchmode branch December 22, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla left review comments

@eriqua eriqua eriqua left review comments

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@tyconsulting tyconsulting

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add support for Virtual Machine Automatic VM Guest Patching
4 participants
@tyconsulting @AlexanderSehr @ahmadabdalla @eriqua