Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Added closing dot in all descriptions of any bicep file #2447

Merged
merged 4 commits into from
Dec 14, 2022
Merged

[Modules] Added closing dot in all descriptions of any bicep file #2447

merged 4 commits into from
Dec 14, 2022

Conversation

SeSeicht
Copy link
Contributor

@SeSeicht SeSeicht commented Dec 13, 2022 •
edited

Description

This adds the missing Dots in the description field of child resources

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@SeSeicht SeSeicht linked an issue Dec 13, 2022 that may be closed by this pull request
[Bug Report]: description of child resources does not always end with a . #2444
Closed
@SeSeicht SeSeicht marked this pull request as ready for review December 13, 2022 14:56
@SeSeicht SeSeicht requested a review from a team as a code owner December 13, 2022 14:56
@SeSeicht SeSeicht enabled auto-merge (squash) December 13, 2022 14:56
@AlexanderSehr AlexanderSehr changed the title Add dot in Description [Modules] Added closing dot in all descriptions of any bicep file Dec 13, 2022
SeSeicht and others added 3 commits December 13, 2022 19:22
@SeSeicht @AlexanderSehr
Update modules/Microsoft.NetApp/netAppAccounts/deploy.bicep
ccdfe68 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@SeSeicht @AlexanderSehr
Update modules/Microsoft.NetApp/netAppAccounts/deploy.bicep
0cd1f4e 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@SeSeicht @AlexanderSehr
Update modules/Microsoft.Synapse/workspaces/deploy.bicep
3b5a78d 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@SeSeicht SeSeicht merged commit d5dc911 into main Dec 14, 2022
@SeSeicht SeSeicht deleted the users/seseicht/childResourcesDescription branch December 14, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@SeSeicht SeSeicht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report]: description of child resources does not always end with a .
2 participants
@SeSeicht @AlexanderSehr