Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Updated Private Endpoint Config to Allows Static IP on Parent Modules #2480

Merged

Conversation

ChrisSidebotham
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham commented Dec 20, 2022

Description

Allow resource modules to deploy static IP configuration to private endpoint via parent module. Resource Modules updated and markdown file for importing Private Endpoints into readme.md

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

As this change effects private endpoint I have ran pipelines for services using private endpoints

Pipeline Badge
DataFactory DataFactory: Factories
Storage Accounts Storage: StorageAccounts
Key Vaults KeyVault: Vaults

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ChrisSidebotham ChrisSidebotham linked an issue Dec 20, 2022 that may be closed by this pull request
@ChrisSidebotham ChrisSidebotham marked this pull request as ready for review December 20, 2022 10:41
@ChrisSidebotham ChrisSidebotham requested a review from a team as a code owner December 20, 2022 10:41
@github-actions
Copy link

github-actions bot commented Dec 20, 2022

Test Results

    1 files      1 suites   3m 22s ⏱️
441 tests 435 ✔️   6 💤 0
475 runs  465 ✔️ 10 💤 0

Results for commit c88d249.

♻️ This comment has been updated with latest results.

@eriqua eriqua changed the title Updated Private Endpoint Config to Allows Static IP on Parent Modules [Modules] Updated Private Endpoint Config to Allows Static IP on Parent Modules Dec 21, 2022
@ChrisSidebotham ChrisSidebotham enabled auto-merge (squash) December 21, 2022 11:00
@ChrisSidebotham ChrisSidebotham added the [cat] modules category: modules label Dec 21, 2022
@ChrisSidebotham ChrisSidebotham merged commit e8cb2bf into main Dec 23, 2022
@ChrisSidebotham ChrisSidebotham deleted the users/csidebotham/2342-PrivateEndpoint-StaticIpConfig branch December 23, 2022 10:02
@azure-pipelines azure-pipelines bot restored the users/csidebotham/2342-PrivateEndpoint-StaticIpConfig branch December 23, 2022 10:03
@AlexanderSehr AlexanderSehr deleted the users/csidebotham/2342-PrivateEndpoint-StaticIpConfig branch May 13, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Factory: Missing ipConfigurations for Private Endpoints
2 participants