Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules]: Microsoft.Network/frontdoors - Fix for Static Validation #2489

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

ChrisSidebotham
Copy link
Contributor

Description

Fixing the readme file as per requirements to pass static validation

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: Frontdoors

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ChrisSidebotham ChrisSidebotham marked this pull request as ready for review December 21, 2022 14:56
@ChrisSidebotham ChrisSidebotham requested a review from a team as a code owner December 21, 2022 14:56
@ChrisSidebotham ChrisSidebotham enabled auto-merge (squash) December 21, 2022 14:56
@ChrisSidebotham ChrisSidebotham added the [cat] modules category: modules label Dec 21, 2022
@ChrisSidebotham ChrisSidebotham added this to the Release v0.9.0 milestone Dec 21, 2022
@ChrisSidebotham ChrisSidebotham linked an issue Dec 21, 2022 that may be closed by this pull request
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@ChrisSidebotham ChrisSidebotham merged commit 39f298a into main Dec 21, 2022
@ChrisSidebotham ChrisSidebotham deleted the users/csidebotham/front-door-static-fix branch December 21, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Fix failing FrontDoors pipeline
2 participants