Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Microsoft.compute/galleries/images - New Feature - SecurityType property #2507

Merged
merged 5 commits into from
Jan 6, 2023

Conversation

shawntmeyer
Copy link
Contributor

@shawntmeyer shawntmeyer commented Dec 24, 2022

Description

Addressing [Issue #2504]: Added the SecurityType parameter to enable adding TrustedLaunch, ConfidentialVM, and ConfidentialVMSupported Security Type images for Gen2 VMs.

  1. Added additional parameter and proper logic to the features object of the resource definition. If template is submitted with V1 hyperV version it will be switched to V2 automatically if SecurityType is specified.
  2. Moved image and application tests into common test folder and deleted the application and image specific tests.

Compute: Galleries

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@shawntmeyer shawntmeyer requested a review from a team as a code owner December 24, 2022 15:24
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Dec 25, 2022
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@AlexanderSehr AlexanderSehr merged commit 9624fda into Azure:main Jan 6, 2023
@shawntmeyer shawntmeyer deleted the Microsoft.Compute/galleries branch January 6, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Allow SecurityType to be defined on Azure Compute Gallery Image Definition
2 participants