Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Microsoft.Compute/VirtualMachines - New Feature - Configured AADJoin Extension #2508

Merged
merged 15 commits into from
Jan 3, 2023
Merged

[Modules] Microsoft.Compute/VirtualMachines - New Feature - Configured AADJoin Extension #2508

merged 15 commits into from
Jan 3, 2023

Conversation

shawntmeyer
Copy link
Contributor

Description

Addresses Issue #2506. Added new parameter, test cases and logic to support configuration of the AADLogin extension for Windows and Linux.

Compute: VirtualMachines

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@shawntmeyer shawntmeyer requested a review from a team as a code owner December 24, 2022 18:03
@shawntmeyer shawntmeyer changed the title [Modules] Compute/virtual machines - New Feature - Configured AADJoin Extension [Modules] Microsoft.Compute/VirtualMachines - New Feature - Configured AADJoin Extension Dec 24, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Dec 25, 2022
@AlexanderSehr AlexanderSehr merged commit 6117464 into Azure:main Jan 3, 2023
@shawntmeyer shawntmeyer deleted the Compute/VirtualMachines branch January 3, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@shawntmeyer shawntmeyer

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shawntmeyer @AlexanderSehr