-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] Updated VNET Gateway to reference PIP module #2509
Conversation
@lsnoddy .. shouldn't the gateway documentation now include the public IP address module in the Cross-referenced modules section? Example from another module: |
Actually true. @lsnoddy, please run the ReadMe generation for that module too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comments: Readme Generation for VNET GW module wasn't run yet.
Thanks for catching @ahmadabdalla and @AlexanderSehr . Ran the readme update script for VNET gateway. |
Description
Refactored the virtualNetworkGateways module to reference the publicIPAddresses module instead of implementing a resource:
Added dnsSettings property to publicIPAddresses module since VNET gateway used one of the parameters (domainNameLabel)
Pipeline references
Type of Change
Please delete options that are not relevant.
Checklist