Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Updated VNET Gateway to reference PIP module #2509

Merged
merged 12 commits into from
Dec 30, 2022

Conversation

lsnoddy
Copy link
Member

@lsnoddy lsnoddy commented Dec 26, 2022

Description

Refactored the virtualNetworkGateways module to reference the publicIPAddresses module instead of implementing a resource:

  • Removed virtualGatewayPublicIP_lock resource since managed by PIP module
  • Removed virtualNetworkGatewayPublicIp_diagnosticSettings since managed by PIP module
  • Removed publicIpDiagnosticsLogsSpecified and publicIpDiagnosticsLogs variables as no longer required

Added dnsSettings property to publicIPAddresses module since VNET gateway used one of the parameters (domainNameLabel)

  • Added optional parameters domainNameLabel, fqdn, reverseFqdn
  • Added dnsSettings in properties

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: VirtualNetworkGateways
Network: PublicIpAddresses

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@lsnoddy lsnoddy added the [cat] modules category: modules label Dec 26, 2022
@lsnoddy lsnoddy requested a review from a team as a code owner December 26, 2022 18:38
@lsnoddy lsnoddy self-assigned this Dec 26, 2022
@ahmadabdalla
Copy link
Contributor

@lsnoddy .. shouldn't the gateway documentation now include the public IP address module in the Cross-referenced modules section?

Example from another module:
https://github.com/Azure/ResourceModules/tree/main/modules/Microsoft.ContainerRegistry/registries#cross-referenced-modules

@AlexanderSehr AlexanderSehr changed the title Updated VNET Gateway to reference PIP module [Modules] Updated VNET Gateway to reference PIP module Dec 27, 2022
@AlexanderSehr
Copy link
Contributor

@lsnoddy .. shouldn't the gateway documentation now include the public IP address module in the Cross-referenced modules section?

Example from another module: https://github.com/Azure/ResourceModules/tree/main/modules/Microsoft.ContainerRegistry/registries#cross-referenced-modules

Actually true. @lsnoddy, please run the ReadMe generation for that module too.

Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other comments: Readme Generation for VNET GW module wasn't run yet.

@lsnoddy
Copy link
Member Author

lsnoddy commented Dec 29, 2022

Thanks for catching @ahmadabdalla and @AlexanderSehr . Ran the readme update script for VNET gateway.

@lsnoddy lsnoddy merged commit f538a48 into Azure:main Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update VNET Gateway to reference PIP module instead of implementing a resource
3 participants