-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] VirtualMachineImages/Images template - adding named Staging Resource Group VM User-Assigned Ids and SIG Image parameters #2510
Conversation
modules/Microsoft.VirtualMachineImages/imageTemplates/.test/common/deploy.test.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.VirtualMachineImages/imageTemplates/.test/common/deploy.test.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.VirtualMachineImages/imageTemplates/.test/common/deploy.test.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.VirtualMachineImages/imageTemplates/.test/common/deploy.test.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.VirtualMachineImages/imageTemplates/.test/common/deploy.test.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.VirtualMachineImages/imageTemplates/.test/common/deploy.test.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.VirtualMachineImages/imageTemplates/.test/common/deploy.test.bicep
Show resolved
Hide resolved
modules/Microsoft.VirtualMachineImages/imageTemplates/.test/advanced/deploy.test.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.VirtualMachineImages/imageTemplates/.test/advanced/deploy.test.bicep
Outdated
Show resolved
Hide resolved
…mmon/deploy.test.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
modules/Microsoft.VirtualMachineImages/imageTemplates/deploy.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.VirtualMachineImages/imageTemplates/deploy.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.VirtualMachineImages/imageTemplates/deploy.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.VirtualMachineImages/imageTemplates/readme.md
Outdated
Show resolved
Hide resolved
modules/Microsoft.VirtualMachineImages/imageTemplates/.test/common/dependencies.bicep
Outdated
Show resolved
Hide resolved
Doing this now. The two PRs are needed for the AVD Accelerator updates so dual impact.
|
modules/Microsoft.VirtualMachineImages/imageTemplates/.test/min/deploy.test.bicep
Outdated
Show resolved
Hide resolved
Please hold off on this PR for a little while today. Have one other property to add to the Image Template after talking to the AVD Accelerator team. Easy update, would like to get it in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking comment to wait for @shawntmeyer's extra property
I've added the parameters and properties to the SharedImageGallery distributor object and tested in my fork/branch. |
Description
Responding to Issues #2505 and #2511. Updated VirtualMachineImages/Images template (Azure VM Image Builder template) to the latest API to include the new capability for a named staging resource group. By naming a staging resource group we can avoid issues with Azure Policies that prevent storage accounts and key vaults without Private Endpoints by creating a permanent exclusion for the named resource group. NOTE: At the moment, the staging group must not exist or the image template will be stuck in creating.
This update also includes the ability to assign user assigned identities to the build VM for accessing storage accounts and key vaults during the image build process from customization scripts. This differs from the User Assigned Identity used by the image builder service which is used to create the resources necessary to build the VM.
Finally, for the Shared Image Gallery (Azure Compute Gallery) distributor object, you can now specify an explicit image version, exclude the image version from the latest, and also specify the type of storage account used to store the image version.
Type of Change
Please delete options that are not relevant.
Checklist