Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] VirtualMachineImages/Images template - adding named Staging Resource Group VM User-Assigned Ids and SIG Image parameters #2510

Conversation

shawntmeyer
Copy link
Contributor

@shawntmeyer shawntmeyer commented Dec 27, 2022

Description

Responding to Issues #2505 and #2511. Updated VirtualMachineImages/Images template (Azure VM Image Builder template) to the latest API to include the new capability for a named staging resource group. By naming a staging resource group we can avoid issues with Azure Policies that prevent storage accounts and key vaults without Private Endpoints by creating a permanent exclusion for the named resource group. NOTE: At the moment, the staging group must not exist or the image template will be stuck in creating.

This update also includes the ability to assign user assigned identities to the build VM for accessing storage accounts and key vaults during the image build process from customization scripts. This differs from the User Assigned Identity used by the image builder service which is used to create the resources necessary to build the VM.

Finally, for the Shared Image Gallery (Azure Compute Gallery) distributor object, you can now specify an explicit image version, exclude the image version from the latest, and also specify the type of storage account used to store the image version.

VirtualMachineImages: ImageTemplates

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@shawntmeyer shawntmeyer requested a review from a team as a code owner December 27, 2022 00:55
@shawntmeyer shawntmeyer changed the title [Modules] VirtualMachineImages/Images template - enable named Staging Resource Group [Modules] VirtualMachineImages/Images template - enable named Staging Resource Group and VM UserAssignedIdenties Dec 27, 2022
@shawntmeyer shawntmeyer changed the title [Modules] VirtualMachineImages/Images template - enable named Staging Resource Group and VM UserAssignedIdenties [Modules] VirtualMachineImages/Images template - enable named Staging Resource Group and VM User-Assigned Identities Dec 27, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Dec 27, 2022
shawntmeyer and others added 2 commits January 3, 2023 08:12
…mmon/deploy.test.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@shawntmeyer
Copy link
Contributor Author

shawntmeyer commented Jan 5, 2023 via email

@shawntmeyer
Copy link
Contributor Author

Please hold off on this PR for a little while today. Have one other property to add to the Image Template after talking to the AVD Accelerator team. Easy update, would like to get it in this PR.

Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking comment to wait for @shawntmeyer's extra property

@shawntmeyer shawntmeyer changed the title [Modules] VirtualMachineImages/Images template - enable named Staging Resource Group and VM User-Assigned Identities [Modules] VirtualMachineImages/Images template - adding named Staging Resource Group VM User-Assigned Ids and SIG Image parameters Jan 5, 2023
@shawntmeyer
Copy link
Contributor Author

Blocking comment to wait for @shawntmeyer's extra property

I've added the parameters and properties to the SharedImageGallery distributor object and tested in my fork/branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
3 participants