Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] DevTest Lab Module (API Version: 2018-09-15) #2513

Merged
merged 21 commits into from
Dec 30, 2022

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Dec 27, 2022

Description

Closes #2420

This PR adds the Microsoft.DevTestLab/Labs module. It uses the currently published API Version 2018-09-15.


Note: This PR is to address the publicly documented API version 2018-09-15. Another PR will be raised to address the undocumented YET API Version 2018-10-15-preview. The newer API has much more features, but static tests are failing as this API version is not showing in the output to get the list of published APIs for this resource type. The module has been uplifted to support the new API in another branch referenced here but cannot be merged yet.


Module Parents and Children

  • Labs [Parent]
    • Artifact Sources [Child]
    • Notification Channels [Child]
    • Policy Sets [Child] = 'default', doesn't use a template reference
      • Policies [Child]
    • Schedules [Child]
    • Virtual Networks [Child]

Test Cases

  • Min: Only the name parameter.
  • Common: Most parameters except two (Mandatory Artifacts for Windows and Linux), which can only be used as an update operation given a dependency on the parent resource ID.

Extension Resources

  • Role Assignments: Updated to cover roles needed for the DevTest Lab resource type.

Bicep Warnings

  • identity property. Supported but not available in the documentation, but available when deployed via the Portal Template export.
  • managedIdentities. Supported but not available in the documentation.

Pipeline references

As this is a new module pipeline, created in the Fork and referenced a deployment from the fork.

Pipeline
DevTestLab: Labs

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added the [cat] modules category: modules label Dec 27, 2022
@ahmadabdalla ahmadabdalla added this to the Release v0.9.0 milestone Dec 27, 2022
@ahmadabdalla ahmadabdalla marked this pull request as ready for review December 27, 2022 21:40
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner December 27, 2022 21:40
@ahmadabdalla ahmadabdalla self-assigned this Dec 27, 2022
@ahmadabdalla ahmadabdalla added the enhancement New feature or request label Dec 28, 2022
@ahmadabdalla ahmadabdalla merged commit b1db89e into Azure:main Dec 30, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/2420_dtl_carml_aa branch January 1, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Azure DevTest Labs (DTL) Module
2 participants