-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] DevTest Lab Module (API Version: 2018-09-15) #2513
Merged
ahmadabdalla
merged 21 commits into
Azure:main
from
ahmadabdalla:users/ahmad/2420_dtl_carml_aa
Dec 30, 2022
Merged
[Modules] DevTest Lab Module (API Version: 2018-09-15) #2513
ahmadabdalla
merged 21 commits into
Azure:main
from
ahmadabdalla:users/ahmad/2420_dtl_carml_aa
Dec 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rceModules into users/ahmad/2420_dtl
…ion' into users/ahmad/dtl_carmlVersion
modules/Microsoft.DevTestLab/labs/.test/common/dependencies.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.DevTestLab/labs/.test/common/deploy.test.bicep
Outdated
Show resolved
Hide resolved
AlexanderSehr
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2420
This PR adds the
Microsoft.DevTestLab/Labs
module. It uses the currently published API Version2018-09-15
.Note: This PR is to address the publicly documented API version
2018-09-15
. Another PR will be raised to address the undocumented YET API Version2018-10-15-preview
. The newer API has much more features, but static tests are failing as this API version is not showing in the output to get the list of published APIs for this resource type. The module has been uplifted to support the new API in another branch referenced here but cannot be merged yet.Module Parents and Children
Test Cases
name
parameter.Extension Resources
Bicep Warnings
identity
property. Supported but not available in the documentation, but available when deployed via the Portal Template export.managedIdentities
. Supported but not available in the documentation.Pipeline references
As this is a new module pipeline, created in the Fork and referenced a deployment from the fork.
Type of Change
Checklist