Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Update galleries readme and add min test #2535

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Jan 6, 2023

Description

Fixing failing static validation
Adding min test

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: Galleries

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added bug Something isn't working enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Jan 6, 2023
@eriqua eriqua linked an issue Jan 6, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Test Results

128 tests   125 ✔️  52s ⏱️
    1 suites      3 💤
    1 files        0

Results for commit 98caee4.

@eriqua eriqua marked this pull request as ready for review January 6, 2023 21:23
@eriqua eriqua requested a review from a team as a code owner January 6, 2023 21:23
@eriqua eriqua merged commit 7af3a61 into main Jan 6, 2023
@eriqua eriqua deleted the users/erikag/2533-fix-galleries branch January 6, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules [cat] testing category: testing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Fix Compute Galleries pipeline
2 participants