Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Add Microsoft.PolicyInsights Remediation Bicep Module #2544

Merged
merged 5 commits into from
Jan 9, 2023

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Jan 9, 2023

Closes #2543

Description

Created the Microsoft.PolicyInsights Remediation Module.

Tests

Follows similar principals for the MS authorization namespace testing methods.

Note

One parameter failureThresholdPercentage is wrapped around the json() function to workaround the limitation of bicep not currently supporting float data type as referenced here Azure/bicep#1386 (comment)

    failureThreshold: {
      percentage: json(failureThresholdPercentage)
    }

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Policy Insights: Remediations

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added enhancement New feature or request [cat] modules category: modules labels Jan 9, 2023
@ahmadabdalla ahmadabdalla self-assigned this Jan 9, 2023
@ahmadabdalla ahmadabdalla marked this pull request as ready for review January 9, 2023 12:45
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner January 9, 2023 12:45
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) January 9, 2023 12:45
@ahmadabdalla ahmadabdalla added this to the Release v0.9.0 milestone Jan 9, 2023
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmadabdalla ahmadabdalla merged commit 476b950 into Azure:main Jan 9, 2023
@ahmadabdalla ahmadabdalla deleted the users/ahmad/policyRem branch February 4, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Enable Microsoft Policy Insights Remediation Bicep Module
2 participants