Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Update Microsoft.DBforPostgreSQL API to '2022-12-01' and add support for data encryption using CMK #2550

Merged
merged 15 commits into from
Jan 10, 2023

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Jan 10, 2023

Closes #2532

Description

  • Updated API to 2022-12-01.
  • Added support for the CMK properties, which allows encrypting the Database using CMK via Azure Key Vault. This resulted in additional parameters and enabling User Identity for the Flexible Server. Note that System Identity is not supported. This implementation aligns to other modules and used Batch, Service Bus Namespace and Storage Account as reference.
  • Improved documentation

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
DbForPostgreSQL: FlexibleServers

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added bug Something isn't working enhancement New feature or request [cat] modules category: modules labels Jan 10, 2023
@ahmadabdalla ahmadabdalla added this to the Release v0.9.0 milestone Jan 10, 2023
@ahmadabdalla ahmadabdalla self-assigned this Jan 10, 2023
@github-actions
Copy link

github-actions bot commented Jan 10, 2023

Test Results

    1 files      1 suites   1m 6s ⏱️
164 tests 160 ✔️ 4 💤 0
181 runs  175 ✔️ 6 💤 0

Results for commit 23c4ffe.

♻️ This comment has been updated with latest results.

@ahmadabdalla ahmadabdalla linked an issue Jan 10, 2023 that may be closed by this pull request
@ahmadabdalla ahmadabdalla marked this pull request as ready for review January 10, 2023 12:53
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner January 10, 2023 12:53
AlexanderSehr
AlexanderSehr previously approved these changes Jan 10, 2023
@AlexanderSehr AlexanderSehr self-requested a review January 10, 2023 20:53
…/dependencies.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@ahmadabdalla ahmadabdalla merged commit 93d5cec into main Jan 10, 2023
@ahmadabdalla ahmadabdalla deleted the users/ahmad/2532_DbForPostgreSQL branch January 10, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Fix DbForPostgreSQL FlexibleServers pipeline
2 participants