Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Microsoft.Cdn - Fixing Descriptions for Pipeline Validation #2554

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

ChrisSidebotham
Copy link
Contributor

Description

Fix for Conditional parameter description

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
CDN: Profiles

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ChrisSidebotham ChrisSidebotham requested a review from a team as a code owner January 11, 2023 12:48
@ChrisSidebotham ChrisSidebotham self-assigned this Jan 11, 2023
@ChrisSidebotham ChrisSidebotham added bug Something isn't working [cat] modules category: modules labels Jan 11, 2023
@ChrisSidebotham ChrisSidebotham added this to the Release v0.9.0 milestone Jan 11, 2023
@github-actions
Copy link

github-actions bot commented Jan 11, 2023

Test Results

127 tests   124 ✔️  52s ⏱️
    1 suites      3 💤
    1 files        0

Results for commit 3248022.

♻️ This comment has been updated with latest results.

@ahmadabdalla
Copy link
Contributor

@ChrisSidebotham the deployment is failing:

Status Message: The request field is required. Could not find member 'roleAssignments' on object of type 'Endpoint'. Path 'properties.roleAssignments', line 1, position 626. (Code:InvalidResource)
[804](https://github.com/Azure/ResourceModules/actions/runs/3892929397/jobs/6644972420#step:4:813)
  
[805](https://github.com/Azure/ResourceModules/actions/runs/3892929397/jobs/6644972420#step:4:814)
  Status Message: The requested resource was not found. (Code:NotFound)
[806](https://github.com/Azure/ResourceModules/actions/runs/3892929397/jobs/6644972420#step:4:815)
  
[807](https://github.com/Azure/ResourceModules/actions/runs/3892929397/jobs/6644972420#step:4:816)
  Status Message: The resource cannot be found

@ChrisSidebotham ChrisSidebotham changed the title [Fixes] Fixing Descriptions for Pipeline Validation [Modules] Microsoft.Cdn - Fixing Descriptions for Pipeline Validation Jan 11, 2023
@ChrisSidebotham
Copy link
Contributor Author

@ChrisSidebotham the deployment is failing:

Status Message: The request field is required. Could not find member 'roleAssignments' on object of type 'Endpoint'. Path 'properties.roleAssignments', line 1, position 626. (Code:InvalidResource)
[804](https://github.com/Azure/ResourceModules/actions/runs/3892929397/jobs/6644972420#step:4:813)
  
[805](https://github.com/Azure/ResourceModules/actions/runs/3892929397/jobs/6644972420#step:4:814)
  Status Message: The requested resource was not found. (Code:NotFound)
[806](https://github.com/Azure/ResourceModules/actions/runs/3892929397/jobs/6644972420#step:4:815)
  
[807](https://github.com/Azure/ResourceModules/actions/runs/3892929397/jobs/6644972420#step:4:816)
  Status Message: The resource cannot be found

Noted that and fixed shortly after - now running clean thanks @ahmadabdalla

@ChrisSidebotham ChrisSidebotham merged commit b94eeaf into main Jan 12, 2023
@ChrisSidebotham ChrisSidebotham deleted the users/csidebotham/cdn-readme-fix branch January 12, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants