Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Microsoft.EventGrid/Subscriptions - New Modules #2564

Merged
merged 23 commits into from
Jan 18, 2023
Merged

[Modules] Microsoft.EventGrid/Subscriptions - New Modules #2564

merged 23 commits into from
Jan 18, 2023

Conversation

ChrisSidebotham
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham commented Jan 13, 2023 •
edited

Description

New Module for Microsoft.EventGrid/Subscriptions

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Build Status

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ChrisSidebotham ChrisSidebotham linked an issue Jan 13, 2023 that may be closed by this pull request
[Feature Request]: Missing Event Grid subscription for Event Topics #2479
Closed
@ChrisSidebotham ChrisSidebotham marked this pull request as ready for review January 13, 2023 14:01
@ChrisSidebotham ChrisSidebotham requested a review from a team as a code owner January 13, 2023 14:01
@ChrisSidebotham ChrisSidebotham enabled auto-merge (squash) January 13, 2023 14:02
@ChrisSidebotham ChrisSidebotham self-assigned this Jan 13, 2023
@ChrisSidebotham ChrisSidebotham added the [cat] modules category: modules label Jan 13, 2023
@ChrisSidebotham ChrisSidebotham added this to the Release v0.9.0 milestone Jan 13, 2023
ahmadabdalla
ahmadabdalla requested changes Jan 15, 2023
View reviewed changes
Copy link
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ChrisSidebotham. I've added some comments. Another thing I noticed is our scope of testing properties is quite small. Is it ok to include more properties in the deploy test i.e. expirationTimeUtc. I think our deploy test files help users understand how to use the module and what is expected in these object, string, etc..

modules/Microsoft.EventGrid/subscriptions/deploy.bicep Outdated Show resolved Hide resolved
modules/Microsoft.EventGrid/subscriptions/deploy.bicep Outdated Show resolved Hide resolved
.azuredevops/modulePipelines/ms.eventgrid.subscriptions.yml Outdated Show resolved Hide resolved
modules/Microsoft.EventGrid/subscriptions/deploy.bicep Outdated Show resolved Hide resolved
modules/Microsoft.EventGrid/subscriptions/deploy.bicep Outdated Show resolved Hide resolved
@ChrisSidebotham @AlexanderSehr
Update modules/Microsoft.EventGrid/eventSubscriptions/.test/common/de…
d7db15f 
…pendencies.bicep


accepting fate

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@ChrisSidebotham ChrisSidebotham merged commit 58dc124 into main Jan 18, 2023
@ChrisSidebotham ChrisSidebotham deleted the users/csidebotham/2479-EventGrid-Subscriptions branch January 18, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

@ahmadabdalla ahmadabdalla ahmadabdalla approved these changes

Assignees

@ChrisSidebotham ChrisSidebotham

Labels
[cat] modules category: modules
Projects
None yet
Milestone
Release v0.9.0
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Missing Event Grid subscription for Event Topics
3 participants
@ChrisSidebotham @AlexanderSehr @ahmadabdalla