Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] resourceGroupResources leftover #2574

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Jan 15, 2023

Description

Replace resourceGroupResources leftovers with nestedDependencies
Fixes Web Sites static validation

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Web: Sites
SignalR Service: SignalR

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added bug Something isn't working [cat] testing category: testing labels Jan 15, 2023
@github-actions
Copy link

Test Results

    1 files  ±    0      1 suites  ±0   1m 58s ⏱️ +9s
248 tests +156  235 ✔️ +144  13 💤 +12  0 ±0 
278 runs  +174  262 ✔️ +162  16 💤 +12  0 ±0 

Results for commit e404eb2. ± Comparison against base commit e6838da.

@eriqua eriqua changed the title [Fixes] resourceGroupResources leftover [Fixes] resourceGroupResources leftover Jan 15, 2023
@eriqua eriqua marked this pull request as ready for review January 15, 2023 16:46
@eriqua eriqua requested a review from a team as a code owner January 15, 2023 16:46
@eriqua eriqua enabled auto-merge (squash) January 15, 2023 16:46
@eriqua eriqua merged commit 3d1f94f into main Jan 15, 2023
@eriqua eriqua deleted the users/erikag/sites-fix branch January 15, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] testing category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants