Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Solve issue with WAF config in Application Gateway #2582

Merged

Conversation

Sdelausnay
Copy link
Contributor

Description

When you deploy the Application Gateway with the SKU of 'VpnGwAZ' then this means the Application Gateway doesn't support WAF.

With the current implementation, when no WAF setting are provided to the module the parameter is still added to the resources but with a 'null' value. When you try to deploy the module in this way, you will get an error that WAF is not supported in the SKU, even if the property is 'null'.

Solved this by not including the WAF config tag to the service when the module parameter is empty. This way you can deploy the Application Gateway with SKU of 'VpnGwV2' not including any WAF.

No dependencies required for this change.

Pipeline references

No pipeline changes

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@Sdelausnay Sdelausnay requested a review from a team as a code owner January 17, 2023 21:11
@AlexanderSehr AlexanderSehr changed the title Solve issue with WAF config in Application Gateway [Fixes] Solve issue with WAF config in Application Gateway Jan 18, 2023
@AlexanderSehr AlexanderSehr added bug Something isn't working [cat] modules category: modules labels Jan 18, 2023
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@AlexanderSehr AlexanderSehr merged commit 3085e9e into Azure:main Jan 19, 2023
@Sdelausnay Sdelausnay deleted the user/sdelausnay/appGwWafConfigIssue branch August 23, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants