Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes] Fixed template spec name gen & added documentation #2605

Merged
merged 3 commits into from
Jan 22, 2023
Merged

[Fixes] Fixed template spec name gen & added documentation #2605

merged 3 commits into from
Jan 22, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jan 22, 2023 •
edited

Description

  • Update the TemplateSpec name generation to bypass the ProviderNamespace as it caused issues for some resource types
  • Added some documentation
Test run
  • ms.aad.domainservices
  • ms.analysisservices.servers
  • ms.apimanagement.service
  • ms.apimanagement.service.apis
  • ms.apimanagement.service.apis.policies
  • ms.apimanagement.service.apiversionsets
  • ms.apimanagement.service.authorizationservers
  • ms.apimanagement.service.backends
  • ms.apimanagement.service.caches
  • ms.apimanagement.service.identityproviders
  • ms.apimanagement.service.namedvalues
  • ms.apimanagement.service.policies
  • ms.apimanagement.service.portalsettings
  • ms.apimanagement.service.products
  • ms.apimanagement.service.products.apis
  • ms.apimanagement.service.products.groups
  • ms.apimanagement.service.subscriptions
  • ms.appconfiguration.configurationstores
  • ms.appconfiguration.configurationstores.keyvalues
  • ms.authorization.locks
  • ms.authorization.locks.resourcegroup
  • ms.authorization.locks.subscription
  • ms.authorization.policyassignments
  • ms.authorization.policyassignments.managementgroup
  • ms.authorization.policyassignments.resourcegroup
  • ms.authorization.policyassignments.subscription
  • ms.authorization.policydefinitions
  • ms.authorization.policydefinitions.managementgroup
  • ms.authorization.policydefinitions.subscription
  • ms.authorization.policyexemptions
  • ms.authorization.policyexemptions.managementgroup
  • ms.authorization.policyexemptions.resourcegroup
  • ms.authorization.policyexemptions.subscription
  • ms.authorization.policysetdefinitions
  • ms.authorization.policysetdefinitions.managementgroup
  • ms.authorization.policysetdefinitions.subscription
  • ms.authorization.roleassignments
  • ms.authorization.roleassignments.managementgroup
  • ms.authorization.roleassignments.resourcegroup
  • ms.authorization.roleassignments.subscription
  • ms.authorization.roledefinitions
  • ms.authorization.roledefinitions.managementgroup
  • ms.authorization.roledefinitions.resourcegroup
  • ms.authorization.roledefinitions.subscription
  • ms.automation.automationaccounts
  • ms.automation.automationaccounts.jobschedules
  • ms.automation.automationaccounts.modules
  • ms.automation.automationaccounts.runbooks
  • ms.automation.automationaccounts.schedules
  • ms.automation.automationaccounts.softwareupdateconfigurations
  • ms.automation.automationaccounts.variables
  • ms.batch.batchaccounts
  • ms.cache.redis
  • ms.cdn.profiles
  • ms.cdn.profiles.endpoints
  • ms.cdn.profiles.endpoints.origins
  • ms.cognitiveservices.accounts
  • ms.compute.availabilitysets
  • ms.compute.diskencryptionsets
  • ms.compute.disks
  • ms.compute.galleries
  • ms.compute.galleries.applications
  • ms.compute.galleries.images
  • ms.compute.images
  • ms.compute.proximityplacementgroups
  • ms.compute.virtualmachines
  • ms.compute.virtualmachines.extensions
  • ms.compute.virtualmachinescalesets
  • ms.compute.virtualmachinescalesets.extensions
  • ms.consumption.budgets
  • ms.containerinstance.containergroups
  • ms.containerregistry.registries
  • ms.containerregistry.registries.replications
  • ms.containerregistry.registries.webhooks
  • ms.containerservice.managedclusters
  • ms.containerservice.managedclusters.agentpools
  • ms.databricks.workspaces
  • ms.datafactory.factories
  • ms.datafactory.factories.integrationruntimes
  • ms.datafactory.factories.managedvirtualnetworks
  • ms.datafactory.factories.managedvirtualnetworks.managedprivateendpoints
  • ms.dataprotection.backupvaults
  • ms.dataprotection.backupvaults.backuppolicies
  • ms.dbforpostgresql.flexibleservers
  • ms.dbforpostgresql.flexibleservers.configurations
  • ms.dbforpostgresql.flexibleservers.databases
  • ms.dbforpostgresql.flexibleservers.firewallrules
  • ms.desktopvirtualization.applicationgroups
  • ms.desktopvirtualization.applicationgroups.applications
  • ms.desktopvirtualization.hostpools
  • ms.desktopvirtualization.scalingplans
  • ms.desktopvirtualization.workspaces
  • ms.devtestlab.labs
  • ms.devtestlab.labs.artifactsources
  • ms.devtestlab.labs.costs
  • ms.devtestlab.labs.notificationchannels
  • ms.devtestlab.labs.policysets.policies
  • ms.devtestlab.labs.schedules
  • ms.devtestlab.labs.virtualnetworks
  • ms.documentdb.databaseaccounts
  • ms.documentdb.databaseaccounts.gremlindatabases
  • ms.documentdb.databaseaccounts.gremlindatabases.graphs
  • ms.documentdb.databaseaccounts.mongodbdatabases
  • ms.documentdb.databaseaccounts.mongodbdatabases.collections
  • ms.documentdb.databaseaccounts.sqldatabases
  • ms.documentdb.databaseaccounts.sqldatabases.containers
  • ms.eventgrid.domains
  • ms.eventgrid.eventsubscriptions
  • ms.eventgrid.systemtopics
  • ms.eventgrid.topics
  • ms.eventhub.namespaces
  • ms.eventhub.namespaces.authorizationrules
  • ms.eventhub.namespaces.disasterrecoveryconfigs
  • ms.eventhub.namespaces.eventhubs
  • ms.eventhub.namespaces.eventhubs.authorizationrules
  • ms.eventhub.namespaces.eventhubs.consumergroups
  • ms.eventhub.namespaces.networkrulesets
  • ms.healthbot.healthbots
  • ms.insights.actiongroups
  • ms.insights.activitylogalerts
  • ms.insights.components
  • ms.insights.diagnosticsettings
  • ms.insights.metricalerts
  • ms.insights.privatelinkscopes
  • ms.insights.privatelinkscopes.scopedresources
  • ms.insights.scheduledqueryrules
  • ms.keyvault.vaults
  • ms.keyvault.vaults.accesspolicies
  • ms.keyvault.vaults.keys
  • ms.keyvault.vaults.secrets
  • ms.kubernetesconfiguration.extensions
  • ms.kubernetesconfiguration.fluxconfigurations
  • ms.logic.workflows
  • ms.machinelearningservices.workspaces
  • ms.machinelearningservices.workspaces.computes
  • ms.maintenance.maintenanceconfigurations
  • ms.managedidentity.userassignedidentities
  • ms.managedservices.registrationdefinitions
  • ms.management.managementgroups
  • ms.netapp.netappaccounts
  • ms.netapp.netappaccounts.capacitypools
  • ms.netapp.netappaccounts.capacitypools.volumes
  • ms.network.applicationgateways
  • ms.network.applicationgatewaywebapplicationfirewallpolicies
  • ms.network.applicationsecuritygroups
  • ms.network.azurefirewalls
  • ms.network.bastionhosts
  • ms.network.connections
  • ms.network.ddosprotectionplans
  • ms.network.dnsresolvers
  • ms.network.expressroutecircuits
  • ms.network.firewallpolicies
  • ms.network.firewallpolicies.rulecollectiongroups
  • ms.network.frontdoors
  • ms.network.ipgroups
  • ms.network.loadbalancers
  • ms.network.loadbalancers.backendaddresspools
  • ms.network.loadbalancers.inboundnatrules
  • ms.network.localnetworkgateways
  • ms.network.natgateways
  • ms.network.networkinterfaces
  • ms.network.networkmanagers
  • ms.network.networkmanagers.connectivityconfigurations
  • ms.network.networkmanagers.networkgroups
  • ms.network.networkmanagers.networkgroups.staticmembers
  • ms.network.networkmanagers.scopeconnections
  • ms.network.networkmanagers.securityadminconfigurations
  • ms.network.networkmanagers.securityadminconfigurations.rulecollections
  • ms.network.networkmanagers.securityadminconfigurations.rulecollections.rules
  • ms.network.networksecuritygroups
  • ms.network.networksecuritygroups.securityrules
  • ms.network.networkwatchers
  • ms.network.networkwatchers.connectionmonitors
  • ms.network.networkwatchers.flowlogs
  • ms.network.privatednszones
  • ms.network.privatednszones.a
  • ms.network.privatednszones.aaaa
  • ms.network.privatednszones.cname
  • ms.network.privatednszones.mx
  • ms.network.privatednszones.ptr
  • ms.network.privatednszones.soa
  • ms.network.privatednszones.srv
  • ms.network.privatednszones.txt
  • ms.network.privatednszones.virtualnetworklinks
  • ms.network.privateendpoints
  • ms.network.privateendpoints.privatednszonegroups
  • ms.network.privatelinkservices
  • ms.network.publicipaddresses
  • ms.network.publicipprefixes
  • ms.network.routetables
  • ms.network.trafficmanagerprofiles
  • ms.network.virtualhubs
  • ms.network.virtualhubs.hubroutetables
  • ms.network.virtualhubs.hubvirtualnetworkconnections
  • ms.network.virtualnetworkgateways
  • ms.network.virtualnetworks
  • ms.network.virtualnetworks.subnets
  • ms.network.virtualnetworks.peerings
  • ms.network.virtualwans
  • ms.network.vpngateways
  • ms.network.vpngateways.connections
  • ms.network.vpngateways.natrules
  • ms.network.vpnsites
  • ms.operationalinsights.workspaces
  • ms.operationalinsights.workspaces.datasources
  • ms.operationalinsights.workspaces.linkedservices
  • ms.operationalinsights.workspaces.linkedstorageaccounts
  • ms.operationalinsights.workspaces.savedsearches
  • ms.operationalinsights.workspaces.storageinsightconfigs
  • ms.operationsmanagement.solutions
  • ms.policyinsights.remediations
  • ms.policyinsights.remediations.managementgroup
  • ms.policyinsights.remediations.resourcegroup
  • ms.policyinsights.remediations.subscription
  • ms.powerbidedicated.capacities
  • ms.recoveryservices.vaults
  • ms.recoveryservices.vaults.backupconfig
  • ms.recoveryservices.vaults.backuppolicies
  • ms.recoveryservices.vaults.backupstorageconfig
  • ms.recoveryservices.vaults.protectioncontainers
  • ms.recoveryservices.vaults.protectioncontainers.protecteditems
  • ms.recoveryservices.vaults.replicationalertsettings
  • ms.recoveryservices.vaults.replicationfabrics
  • ms.recoveryservices.vaults.replicationfabrics.replicationprotectioncontainers
  • ms.recoveryservices.vaults.replicationfabrics.replicationprotectioncontainers.mappings
  • ms.recoveryservices.vaults.replicationpolicies
  • ms.resources.deploymentscripts
  • ms.resources.resourcegroups
  • ms.resources.tags
  • ms.resources.tags.resourcegroups
  • ms.resources.tags.subscriptions
  • ms.security.azuresecuritycenter
  • ms.servicebus.namespaces
  • ms.servicebus.namespaces.authorizationrules
  • ms.servicebus.namespaces.disasterrecoveryconfigs
  • ms.servicebus.namespaces.migrationconfigurations
  • ms.servicebus.namespaces.networkrulesets
  • ms.servicebus.namespaces.queues
  • ms.servicebus.namespaces.queues.authorizationrules
  • ms.servicebus.namespaces.topics
  • ms.servicebus.namespaces.topics.authorizationrules
  • ms.servicefabric.clusters
  • ms.servicefabric.clusters.applicationtypes
  • ms.signalrservice.signalr
  • ms.signalrservice.webpubsub
  • ms.sql.managedinstances
  • ms.sql.managedinstances.administrators
  • ms.sql.managedinstances.databases
  • ms.sql.managedinstances.databases.backuplongtermretentionpolicies
  • ms.sql.managedinstances.databases.backupshorttermretentionpolicies
  • ms.sql.managedinstances.encryptionprotector
  • ms.sql.managedinstances.keys
  • ms.sql.managedinstances.securityalertpolicies
  • ms.sql.managedinstances.vulnerabilityassessments
  • ms.sql.servers
  • ms.sql.servers.databases
  • ms.sql.servers.elasticpools
  • ms.sql.servers.firewallrules
  • ms.sql.servers.keys
  • ms.sql.servers.securityalertpolicies
  • ms.sql.servers.virtualnetworkrules
  • ms.sql.servers.vulnerabilityassessments
  • ms.storage.storageaccounts
  • ms.storage.storageaccounts.blobservices
  • ms.storage.storageaccounts.blobservices.containers
  • ms.storage.storageaccounts.blobservices.containers.immutabilitypolicies
  • ms.storage.storageaccounts.fileservices
  • ms.storage.storageaccounts.fileservices.shares
  • ms.storage.storageaccounts.localusers
  • ms.storage.storageaccounts.managementpolicies
  • ms.storage.storageaccounts.queueservices
  • ms.storage.storageaccounts.queueservices.queues
  • ms.storage.storageaccounts.tableservices
  • ms.storage.storageaccounts.tableservices.tables
  • ms.synapse.privatelinkhubs
  • ms.synapse.workspaces
  • ms.synapse.workspaces.keys
  • ms.virtualmachineimages.imagetemplates
  • ms.web.connections
  • ms.web.hostingenvironments
  • ms.web.serverfarms
  • ms.web.sites
  • ms.web.sites.config-appsettings
  • ms.web.sites.config-authsettingsv2
  • ms.web.sites.slots
  • ms.web.sites.slots.config-appsettings
  • ms.web.sites.slots.config-authsettingsv2
  • ms.web.staticsites
  • ms.web.staticsites.config
  • ms.web.staticsites.customdomains
  • ms.web.staticsites.linkedbackends

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: NetworkWatchers

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner January 22, 2023 08:39
@AlexanderSehr AlexanderSehr self-assigned this Jan 22, 2023
@AlexanderSehr AlexanderSehr added bug Something isn't working [cat] publishing category: publishing labels Jan 22, 2023
This was linked to issues Jan 22, 2023
[Failed pipeline] Network: NetworkInterfaces #2595
Closed
[Failed pipeline] Automation: AutomationAccounts #2596
Closed
[Failed pipeline] Network: Network Managers #2598
Closed
[Failed pipeline] Storage: StorageAccounts #2599
Closed
@github-actions
Copy link

Test Results

    1 files  ±    0      1 suites  ±0   51s ⏱️ - 3m 23s
126 tests  - 352  125 ✔️  - 346  1 💤  - 6  0 ❌ ±0 
133 runs   - 379  131 ✔️  - 370  2 💤  - 9  0 ❌ ±0 

Results for commit 6b820d1. ± Comparison against base commit 8e03278.

This was linked to issues Jan 22, 2023
[Failed pipeline] NetApp: NetAppAccounts #2600
Closed
[Failed pipeline] Network: NetworkSecurityGroups #2601
Closed
[Failed pipeline] HealthBot: HealthBots #2603
Closed
[Failed pipeline] Batch: BatchAccounts #2604
Closed
[Failed pipeline] Network: NetworkWatchers #2597
Closed
[Failed pipeline] Network: VPNGateways #2602
Closed
AlexanderSehr and others added 2 commits January 22, 2023 09:54
@AlexanderSehr @ahmadabdalla
Update utilities/pipelines/resourcePublish/Get-TemplateSpecsName.ps1
81ed223 
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
@AlexanderSehr @ahmadabdalla
Update utilities/pipelines/resourcePublish/Get-TemplateSpecsName.ps1
ef43c12 
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
@AlexanderSehr AlexanderSehr merged commit 46f84ae into main Jan 22, 2023
@AlexanderSehr AlexanderSehr deleted the users/alsehr/2595_name branch January 22, 2023 08:56
@AlexanderSehr
Copy link
Contributor Author

Thanks for the quick review @ahmadabdalla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
bug Something isn't working [cat] publishing category: publishing
Projects
None yet
Milestone
No milestone
2 participants
@AlexanderSehr @ahmadabdalla