Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Bump StorageAccount and add params #2617

Merged
merged 2 commits into from
Jan 26, 2023
Merged

[Modules] Bump StorageAccount and add params #2617

merged 2 commits into from
Jan 26, 2023

Conversation

MariusStorhaug
Copy link
Contributor

Description

  • Bumped version of Storage Account to most recent (2022-09-01)
  • Added a couple of extra parameters:
    • allowCrossTenantReplication
    • allowedCopyScope
    • allowSharedKeyAccess
    • customDomainName
    • customDomainUseSubDomainName
    • defaultToOAuthAuthentication
    • dnsEndpointType
    • isLocalUserEnabled

Pipeline references

Pipeline
Storage: StorageAccounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug requested a review from a team as a code owner January 26, 2023 15:05
@MariusStorhaug MariusStorhaug self-assigned this Jan 26, 2023
@MariusStorhaug MariusStorhaug added the [cat] modules category: modules label Jan 26, 2023
@MariusStorhaug MariusStorhaug added this to the Release v0.10.0 milestone Jan 26, 2023
@MariusStorhaug MariusStorhaug linked an issue Jan 26, 2023 that may be closed by this pull request
[Feature Request]: Uplift Storage account module to latest API version (2022-05-01) and add new properties where needed #2573
Closed
@github-actions
Copy link

github-actions bot commented Jan 26, 2023 •
edited

Test Results

    1 files      1 suites   3m 18s ⏱️
478 tests 471 ✔️   7 💤 0 ❌
512 runs  501 ✔️ 11 💤 0 ❌

Results for commit 6e4db60.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr added the enhancement New feature or request label Jan 26, 2023
@MariusStorhaug MariusStorhaug merged commit 78ba31a into main Jan 26, 2023
@MariusStorhaug MariusStorhaug deleted the users/mast/saBump branch January 26, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@MariusStorhaug MariusStorhaug

Labels
[cat] modules category: modules enhancement New feature or request
Projects
Backlog
Status: Done
Milestone
Release v0.10.0
2 participants
@MariusStorhaug @AlexanderSehr