Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] CI environment - Skip deployment if static failing #2628

Merged
merged 6 commits into from
Jan 30, 2023

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Jan 30, 2023

Description

Fixing condition blocking deployment validation if static is failing, i.e., this shouldn't happen:

image
but should be
image

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Synapse: Workspaces (failing on static validation and correctly skipping deployment)
Insights: ActionGroups

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added bug Something isn't working [cat] pipelines category: pipelines [cat] github category: GitHub labels Jan 30, 2023
@eriqua eriqua requested a review from a team as a code owner January 30, 2023 19:45
@eriqua eriqua enabled auto-merge (squash) January 30, 2023 19:45
@eriqua eriqua merged commit d80714f into main Jan 30, 2023
@eriqua eriqua deleted the users/erikag/skip-jobs-failing branch January 30, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] github category: GitHub [cat] pipelines category: pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants