Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Updated Disk Encryption Set to latest published API version (2022-07-02) #2636

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

ahmadabdalla
Copy link
Contributor

Closes #2632

Description

Updated the DES module to the latest API version to fix failing pipeline:

Added support for:

  • federatedClientId: Multi-tenant application client id to access key vault in a different tenant.
  • User Assigned Managed Identity support. Set the system assigned to default to true.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: DiskEncryptionSets

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules labels Jan 31, 2023
@ahmadabdalla ahmadabdalla added this to the Release v0.10.0 milestone Jan 31, 2023
@ahmadabdalla ahmadabdalla self-assigned this Jan 31, 2023
@ahmadabdalla ahmadabdalla marked this pull request as ready for review January 31, 2023 10:10
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner January 31, 2023 10:10
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) January 31, 2023 10:11
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Test Results

  1 files  ±  0    1 suites  ±0   20s ⏱️ -31s
52 tests  - 41  51 ✔️  - 39  1 💤  - 1  0  - 1 
52 runs   - 81  51 ✔️  - 75  1 💤  - 5  0  - 1 

Results for commit 9f3329c. ± Comparison against base commit d80714f.

This pull request removes 93 and adds 52 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces/keys] used resource type [workspaces/keys] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2022-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2022-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [vaults/accessPolicies] should use one of the recent API version(s). Currently using [2021-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [workspaces/keys] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Synapse/workspaces] used resource type [workspaces] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Synapse/workspaces/keys] All apiVersion properties should be set to a static, hard-coded value
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/diskEncryptionSets] used resource type [diskEncryptionSets] should use one of the recent API version(s). Currently using [2022-07-02]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/diskEncryptionSets] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/diskEncryptionSets] used resource type [vaults/accessPolicies] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Compute/diskEncryptionSets] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
…
This pull request removes 2 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Synapse/workspaces/keys] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Synapse/workspaces] JSON test files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Compute/diskEncryptionSets] JSON test files in the .test folder should be valid json

@ahmadabdalla ahmadabdalla merged commit a3a9236 into main Feb 1, 2023
@ahmadabdalla ahmadabdalla deleted the users/ahmad/pipelineFixes branch February 1, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] Compute: DiskEncryptionSets
2 participants