Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Added Microsoft Purview Account module #2646

Merged
merged 71 commits into from
Feb 6, 2023

Conversation

tyconsulting
Copy link
Contributor

@tyconsulting tyconsulting commented Feb 3, 2023

Closes #2185

Description

Add Microsoft Purview Account module. Supports Private Endpoints for:

  • Purview account
  • Purview Portal
  • Managed Storage Account (Blob and Queue services)
  • Managed Event Hub Namespace

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Purview: Accounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@tyconsulting tyconsulting changed the title Add Microsoft Purview Account module #2185 Add Microsoft Purview Account module Feb 3, 2023
@tyconsulting tyconsulting marked this pull request as ready for review February 3, 2023 13:24
@tyconsulting tyconsulting requested a review from a team as a code owner February 3, 2023 13:24
@eriqua eriqua changed the title Add Microsoft Purview Account module [Modules] New module Microsoft Purview Account Feb 3, 2023
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules labels Feb 3, 2023
@ahmadabdalla ahmadabdalla self-requested a review February 3, 2023 18:50
Copy link
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyconsulting Thanks for your contribution. I have provided feedback and required changes. Please feel free to reach out or comment if you have any questions. Happy to support you. I would also suggest you sync your branch with CARML latest to get the latest updates.

README.md Outdated Show resolved Hide resolved
modules/Microsoft.Purview/accounts/deploy.bicep Outdated Show resolved Hide resolved
modules/Microsoft.Purview/accounts/deploy.bicep Outdated Show resolved Hide resolved
modules/Microsoft.Purview/accounts/deploy.bicep Outdated Show resolved Hide resolved
modules/Microsoft.Purview/accounts/deploy.bicep Outdated Show resolved Hide resolved
tyconsulting and others added 11 commits February 5, 2023 16:55
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
tyconsulting and others added 25 commits February 6, 2023 18:47
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
@ahmadabdalla ahmadabdalla merged commit 08bec03 into Azure:main Feb 6, 2023
@tyconsulting tyconsulting deleted the fix/purview branch February 27, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Modules] Create new Microsoft.Purview/accounts module
4 participants