Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Added Database for MySQL Flexible Server Module #2657

Merged
merged 42 commits into from
Feb 27, 2023
Merged

[Modules] Added Database for MySQL Flexible Server Module #2657

merged 42 commits into from
Feb 27, 2023

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Feb 6, 2023 •
edited

Closes #2647

Description

New Module for Microsoft Database for MySQL Flexible Servers

  • Supports Public and Private Servers
  • Geo backed up Servers with CMK
  • Child modules for (config, firewall rules and databases)

Aligns to the PostgreSQL Flexible server's module we have in the CARML library.

Pipeline references

Pipeline
DbForMySQL: FlexibleServers

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla requested a review from a team as a code owner February 6, 2023 04:00
@ahmadabdalla ahmadabdalla marked this pull request as draft February 6, 2023 04:00
@ahmadabdalla ahmadabdalla changed the title Added MySQL Flexible [Modules] Added Database for MySQL Flexible Module Feb 6, 2023
@ahmadabdalla ahmadabdalla self-assigned this Feb 6, 2023
@ahmadabdalla ahmadabdalla added enhancement New feature or request [cat] modules category: modules labels Feb 6, 2023
@ahmadabdalla ahmadabdalla changed the title [Modules] Added Database for MySQL Flexible Module [Modules] Added Database for MySQL Flexible Server Module Feb 6, 2023
@ahmadabdalla ahmadabdalla marked this pull request as ready for review February 8, 2023 05:15
@ahmadabdalla @AlexanderSehr
Update modules/Microsoft.DBforMySQL/flexibleServers/.bicep/nested_rol…
6d429b5 
…eAssignments.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@ahmadabdalla ahmadabdalla marked this pull request as draft February 24, 2023 05:29
@ahmadabdalla ahmadabdalla mentioned this pull request Feb 24, 2023
Open
@ahmadabdalla ahmadabdalla marked this pull request as ready for review February 24, 2023 23:07
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) February 24, 2023 23:08
@ahmadabdalla ahmadabdalla merged commit 1a3e021 into Azure:main Feb 27, 2023
@ahmadabdalla ahmadabdalla deleted the users/ahmad/2647_mySqlFlexible branch February 27, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@ahmadabdalla ahmadabdalla

Labels
[cat] modules category: modules enhancement New feature or request
Projects
Backlog
Status: Done
Milestone
Release v0.10.0
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add module for Azure Database for MySQL Flexible Server
2 participants
@ahmadabdalla @AlexanderSehr